Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add native schema support for org.fugerit.java:fj-doc-base and org.fugeri.tjava:fj-doc-freemarker #557

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

fugerit79
Copy link

What does this PR do?

I recently added to one of my project the native metadata needed for GraalVM :
https://github.com/fugerit-org/fj-doc/tree/main/fj-doc-base
https://github.com/fugerit-org/fj-doc/tree/main/fj-doc-freemarker

As for the "CONTRIBUTING" section, the metadata are mantained and tested direcly in my project repository, But as I understand a pull request is needed to be listed here https://www.graalvm.org/native-image/libraries-and-frameworks/

PS: This is my first pull request here, so I hope i filled it property. I tried to read the documentation and I hope I understood it properly.
PSS: Thanks a lot for your great work with GraalVM, we converted already a few production projects to AOT and we are very happy for the gain in

Code sections where the PR accesses files, network, docker or some external service

Tests are note enabled as the metadata and testing is provided direclty on the prohect repository :

https://github.com/fugerit-org/fj-doc

A module test project using https://quarkus.io/ is included :
https://github.com/fugerit-org/fj-doc/tree/main/fj-doc-native-quarkus

And a workflow for continuous testing :
https://github.com/fugerit-org/fj-doc/actions/workflows/build_fj-doc-native-quarkus_test.yml

Checklist before merging

@fugerit79 fugerit79 requested a review from fniephaus as a code owner November 1, 2024 23:14
@fugerit79 fugerit79 changed the title 1 add native schema support for orgfugeritjavafj doc base and orgfugeritjavafj doc freemarker 1 add native schema support for org.fugerit.java:fj doc base and org.fugeri.tjava:fj doc freemarker Nov 1, 2024
@fugerit79 fugerit79 changed the title 1 add native schema support for org.fugerit.java:fj doc base and org.fugeri.tjava:fj doc freemarker Add native schema support for org.fugerit.java:fj-doc-base and org.fugeri.tjava:fj-doc-freemarker Nov 1, 2024
@mttfranci mttfranci force-pushed the 1-add-native-schema-support-for-orgfugeritjavafj-doc-base-and-orgfugeritjavafj-doc-freemarker branch from f18fed5 to 81dd313 Compare November 4, 2024 14:15
@fugerit79 fugerit79 force-pushed the 1-add-native-schema-support-for-orgfugeritjavafj-doc-base-and-orgfugeritjavafj-doc-freemarker branch from 81dd313 to 1dee98b Compare November 8, 2024 19:08
…javafj-doc-base-and-orgfugeritjavafj-doc-freemarker
@fugerit79
Copy link
Author

Hello, may I know if got something wrong about the pull request @fniephaus ?

As far as I have understood as we included in the project repository the native metadata, tests and so on are handled on our repository. Is it correct?

Thanks in advance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant