module block proposal implementation #476
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello KamikazeSquirrel, thanks for contributing a PR to our project! We use the Oracle Contributor Agreement to make the copyright of contributions clear. We don't have a record of you having signed this yet, based on your email address 64982603+KamikazeSquirrel -(at)- users -(dot)- noreply -(dot)- github -(dot)- com. You can sign it at that link. If you think you've already signed it, please comment below and we'll check. |
wirthi
requested review from
woess,
wirthi and
eleinadani
and removed request for
woess
wirthi
reviewed
Jul 14, 2021
...l-js/src/com.oracle.truffle.js.test/src/com/oracle/truffle/js/test/interop/ESModuleTest.java
Outdated
Show resolved
Hide resolved
...l-js/src/com.oracle.truffle.js.test/src/com/oracle/truffle/js/test/interop/ESModuleTest.java
Outdated
Show resolved
Hide resolved
....test/src/com/oracle/truffle/js/test/interop/resources/moduleblock/benchmark/kMeansModule.js
Outdated
Show resolved
Hide resolved
wirthi
reviewed
Jul 14, 2021
graal-js/src/com.oracle.js.parser/src/com/oracle/js/parser/Parser.java
Outdated
Show resolved
Hide resolved
...l-js/src/com.oracle.truffle.js.test/src/com/oracle/truffle/js/test/interop/ESModuleTest.java
Show resolved
Hide resolved
...cle/truffle/js/test/interop/resources/moduleblock/benchmark/kMeansModuleModuleBlockImport.js
Outdated
Show resolved
Hide resolved
graal-js/src/com.oracle.truffle.js/src/com/oracle/truffle/js/builtins/ConstructorBuiltins.java
Outdated
Show resolved
Hide resolved
...c/com.oracle.truffle.js/src/com/oracle/truffle/js/builtins/ModuleBlockPrototypeBuiltins.java
Show resolved
Hide resolved
graal-js/src/com.oracle.truffle.js/src/com/oracle/truffle/js/builtins/GlobalBuiltins.java
Outdated
Show resolved
Hide resolved
graal-js/src/com.oracle.truffle.js/src/com/oracle/truffle/js/builtins/GlobalBuiltins.java
Outdated
Show resolved
Hide resolved
...c/com.oracle.truffle.js/src/com/oracle/truffle/js/builtins/ModuleBlockPrototypeBuiltins.java
Outdated
Show resolved
Hide resolved
graal-js/src/com.oracle.truffle.js/src/com/oracle/truffle/js/nodes/promise/ImportCallNode.java
Outdated
Show resolved
Hide resolved
graal-js/src/com.oracle.truffle.js/src/com/oracle/truffle/js/runtime/JSRealm.java
Outdated
Show resolved
Hide resolved
eleinadani
reviewed
Jul 15, 2021
graal-js/src/com.oracle.js.parser/src/com/oracle/js/parser/Parser.java
Outdated
Show resolved
Hide resolved
eleinadani
reviewed
Jul 15, 2021
graal-js/src/com.oracle.js.parser/src/com/oracle/js/parser/Parser.java
Outdated
Show resolved
Hide resolved
eleinadani
reviewed
Jul 15, 2021
graal-js/src/com.oracle.js.parser/src/com/oracle/js/parser/Parser.java
Outdated
Show resolved
Hide resolved
eleinadani
reviewed
Jul 15, 2021
...l-js/src/com.oracle.truffle.js.parser/src/com/oracle/truffle/js/parser/GraalJSEvaluator.java
Outdated
Show resolved
Hide resolved
eleinadani
reviewed
Jul 15, 2021
...l-js/src/com.oracle.truffle.js.test/src/com/oracle/truffle/js/test/interop/ESModuleTest.java
Show resolved
Hide resolved
eleinadani
reviewed
Jul 15, 2021
...om/oracle/truffle/js/test/interop/resources/moduleblock/benchmark/kMeansModuleModuleBlock.js
Show resolved
Hide resolved
eleinadani
reviewed
Jul 15, 2021
...c/com.oracle.truffle.js/src/com/oracle/truffle/js/builtins/ModuleBlockPrototypeBuiltins.java
Outdated
Show resolved
Hide resolved
eleinadani
reviewed
Jul 15, 2021
graal-js/src/com.oracle.truffle.js/src/com/oracle/truffle/js/nodes/module/ModuleBlockNode.java
Show resolved
Hide resolved
eleinadani
reviewed
Jul 15, 2021
graal-js/src/com.oracle.truffle.js/src/com/oracle/truffle/js/nodes/promise/ImportCallNode.java
Outdated
Show resolved
Hide resolved
eleinadani
reviewed
Jul 15, 2021
graal-js/src/com.oracle.truffle.js/src/com/oracle/truffle/js/nodes/promise/ImportCallNode.java
Outdated
Show resolved
Hide resolved
eleinadani
reviewed
Jul 15, 2021
...l-js/src/com.oracle.truffle.js/src/com/oracle/truffle/js/runtime/builtins/JSModuleBlock.java
Show resolved
Hide resolved
Changed DynamicObjectLibrary code to JSObjectUtilCode, added an assertion and activated an Error.
|
Hello KamikazeSquirrel, thanks for contributing a PR to our project! We use the Oracle Contributor Agreement to make the copyright of contributions clear. We don't have a record of you having signed this yet, based on your email address 64982603+KamikazeSquirrel -(at)- users -(dot)- noreply -(dot)- github -(dot)- com. You can sign it at that link. If you think you've already signed it, please comment below and we'll check. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The pull request is for the implementation of the module block stage 2 proposal:
https://github.com/tc39/proposal-js-module-blocks