[storage] [lint] Re-enable several rules #218
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -10,39 +10,49 @@ option java_outer_classname = "BackendNullProto"; | |
|
|
||
| option go_package = "github.com/opiproject/opi-api/storage/v1alpha1/gen/go"; | ||
|
|
||
| import "google/api/client.proto"; | ||
| import "google/api/resource.proto"; | ||
| import "google/protobuf/empty.proto"; | ||
| import "google/api/annotations.proto"; | ||
| import "google/api/field_behavior.proto"; | ||
| import "google/protobuf/field_mask.proto"; | ||
|
|
||
| import "object_key.proto"; | ||
| import "uuid.proto"; | ||
|
|
||
| // Back End (network-facing) APIs. This is debug interface for null block devices. | ||
| service NullDebugService { | ||
| rpc CreateNullDebug (CreateNullDebugRequest) returns (NullDebug) { | ||
| option (google.api.http) = { | ||
| post: "/v1/{parent=subsystems}" | ||
|
There was a problem hiding this comment. don't review URLs, they will be fixed here #188 |
||
| body: "null_debug" | ||
| }; | ||
| option (google.api.method_signature) = "parent,null_debug,null_debug_id"; | ||
| } | ||
| rpc DeleteNullDebug (DeleteNullDebugRequest) returns (google.protobuf.Empty) { | ||
| option (google.api.http) = { | ||
| delete: "/v1/{name=subsystems}/{subsystem}" | ||
| }; | ||
| option (google.api.method_signature) = "name"; | ||
| } | ||
| rpc UpdateNullDebug (UpdateNullDebugRequest) returns (NullDebug) { | ||
| option (google.api.http) = { | ||
| patch: "/v1/{null_debug.name=subsystems}" | ||
| body: "null_debug" | ||
| }; | ||
| option (google.api.method_signature) = "null_debug,update_mask"; | ||
| } | ||
| rpc ListNullDebugs (ListNullDebugsRequest) returns (ListNullDebugsResponse) { | ||
| option (google.api.http) = { | ||
| get: "/v1/{parent=subsystems}" | ||
| }; | ||
| option (google.api.method_signature) = "parent"; | ||
| } | ||
| rpc GetNullDebug (GetNullDebugRequest) returns (NullDebug) { | ||
| option (google.api.http) = { | ||
| get: "/v1/{name=subsystems}/{subsystem}" | ||
| }; | ||
| option (google.api.method_signature) = "name"; | ||
| } | ||
| rpc NullDebugStats (NullDebugStatsRequest) returns (NullDebugStatsResponse) {} | ||
| } | ||
|
|
@@ -55,30 +65,46 @@ message NullDebug { | |
| } | ||
|
|
||
| message CreateNullDebugRequest { | ||
| string parent = 1 [ | ||
| (google.api.field_behavior) = REQUIRED, | ||
| (google.api.resource_reference).type = "library.googleapis.com/Publisher" | ||
| ]; | ||
| NullDebug null_debug = 2 [(google.api.field_behavior) = REQUIRED]; | ||
| string null_debug_id = 3; | ||
| } | ||
|
|
||
| message DeleteNullDebugRequest { | ||
| string name = 1 [ | ||
| (google.api.field_behavior) = REQUIRED, | ||
| (google.api.resource_reference).type = "opi.storage.v1/NVMeSubsystem" | ||
| ]; | ||
| } | ||
|
|
||
| message UpdateNullDebugRequest { | ||
| NullDebug null_debug = 1; | ||
| // The list of fields to update. | ||
| google.protobuf.FieldMask update_mask = 2; | ||
| } | ||
|
|
||
| message ListNullDebugsRequest { | ||
| string parent = 1 [ | ||
| (google.api.field_behavior) = REQUIRED, | ||
| (google.api.resource_reference).type = "library.googleapis.com/Publisher" | ||
| ]; | ||
| int32 page_size = 2; | ||
| string page_token = 3; | ||
| } | ||
|
|
||
| message ListNullDebugsResponse { | ||
| repeated NullDebug null_debugs = 1; | ||
| string next_page_token = 2; | ||
| } | ||
|
|
||
| message GetNullDebugRequest { | ||
| string name = 1 [ | ||
| (google.api.field_behavior) = REQUIRED, | ||
| (google.api.resource_reference).type = "opi.storage.v1/NVMeSubsystem" | ||
| ]; | ||
| } | ||
|
|
||
| message NullDebugStatsRequest { | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -10,38 +10,48 @@ option java_outer_classname = "BackendNvmeTcpProto"; | |
|
|
||
| option go_package = "github.com/opiproject/opi-api/storage/v1alpha1/gen/go"; | ||
|
|
||
| import "google/api/client.proto"; | ||
| import "google/api/resource.proto"; | ||
| import "google/protobuf/empty.proto"; | ||
| import "google/api/annotations.proto"; | ||
| import "google/api/field_behavior.proto"; | ||
| import "google/protobuf/field_mask.proto"; | ||
|
|
||
| import "object_key.proto"; | ||
|
|
||
| // Back End (network-facing) APIs. NVMe/TCP and NVMe/RoCEv2 protocols are covered by this service. | ||
| service NVMfRemoteControllerService { | ||
| rpc CreateNVMfRemoteController (CreateNVMfRemoteControllerRequest) returns (NVMfRemoteController) { | ||
| option (google.api.http) = { | ||
|
There was a problem hiding this comment. don't review URLs, they will be fixed here #188 |
||
| post: "/v1/{parent=subsystems}" | ||
| body: "nv_mf_remote_controller" | ||
| }; | ||
| option (google.api.method_signature) = "parent,nv_mf_remote_controller,nv_mf_remote_controller_id"; | ||
| } | ||
| rpc DeleteNVMfRemoteController (DeleteNVMfRemoteControllerRequest) returns (google.protobuf.Empty) { | ||
| option (google.api.http) = { | ||
| delete: "/v1/{name=subsystems}/{subsystem}" | ||
| }; | ||
| option (google.api.method_signature) = "name"; | ||
| } | ||
| rpc UpdateNVMfRemoteController (UpdateNVMfRemoteControllerRequest) returns (NVMfRemoteController) { | ||
| option (google.api.http) = { | ||
| patch: "/v1/{nv_mf_remote_controller.name=subsystems}" | ||
| body: "nv_mf_remote_controller" | ||
| }; | ||
| option (google.api.method_signature) = "nv_mf_remote_controller,update_mask"; | ||
| } | ||
| rpc ListNVMfRemoteControllers (ListNVMfRemoteControllersRequest) returns (ListNVMfRemoteControllersResponse) { | ||
| option (google.api.http) = { | ||
| get: "/v1/{parent=subsystems}" | ||
| }; | ||
| option (google.api.method_signature) = "parent"; | ||
| } | ||
| rpc GetNVMfRemoteController (GetNVMfRemoteControllerRequest) returns (NVMfRemoteController) { | ||
| option (google.api.http) = { | ||
| get: "/v1/{name=subsystems}/{subsystem}" | ||
| }; | ||
| option (google.api.method_signature) = "name"; | ||
| } | ||
| rpc NVMfRemoteControllerReset (NVMfRemoteControllerResetRequest) returns (google.protobuf.Empty) {} | ||
| rpc NVMfRemoteControllerStats (NVMfRemoteControllerStatsRequest) returns (NVMfRemoteControllerStatsResponse) {} | ||
|
|
@@ -65,31 +75,48 @@ message NVMfRemoteController { | |
| } | ||
|
|
||
| message CreateNVMfRemoteControllerRequest { | ||
| string parent = 1 [ | ||
| (google.api.field_behavior) = REQUIRED, | ||
| (google.api.resource_reference).type = "library.googleapis.com/Publisher" | ||
| ]; | ||
| NVMfRemoteController nv_mf_remote_controller = 2 [(google.api.field_behavior) = REQUIRED]; | ||
| string nv_mf_remote_controller_id = 3; | ||
| } | ||
|
|
||
| message DeleteNVMfRemoteControllerRequest { | ||
| // object's unique identifier | ||
| string name = 1 [ | ||
| (google.api.field_behavior) = REQUIRED, | ||
| (google.api.resource_reference).type = "opi.storage.v1/NVMeSubsystem" | ||
| ]; | ||
| } | ||
|
|
||
| message UpdateNVMfRemoteControllerRequest { | ||
| NVMfRemoteController nv_mf_remote_controller = 1; | ||
| // The list of fields to update. | ||
| google.protobuf.FieldMask update_mask = 2; | ||
| } | ||
|
|
||
| message ListNVMfRemoteControllersRequest { | ||
| string parent = 1 [ | ||
| (google.api.field_behavior) = REQUIRED, | ||
| (google.api.resource_reference).type = "library.googleapis.com/Publisher" | ||
| ]; | ||
| int32 page_size = 2; | ||
| string page_token = 3; | ||
| } | ||
|
|
||
| message ListNVMfRemoteControllersResponse { | ||
| repeated NVMfRemoteController nv_mf_remote_controllers = 1; | ||
| string next_page_token = 2; | ||
| } | ||
|
|
||
| message GetNVMfRemoteControllerRequest { | ||
| // object's unique identifier | ||
| string name = 1 [ | ||
| (google.api.field_behavior) = REQUIRED, | ||
| (google.api.resource_reference).type = "opi.storage.v1/NVMeSubsystem" | ||
| ]; | ||
| } | ||
|
|
||
| message NVMfRemoteControllerResetRequest { | ||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
don't review URLs, they will be fixed here #188