Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/atac count #762

Merged
merged 34 commits into from
Aug 23, 2024
Merged

Feature/atac count #762

merged 34 commits into from
Aug 23, 2024

Conversation

VladimirShitov
Copy link
Collaborator

@VladimirShitov VladimirShitov commented Mar 22, 2024

Changelog

  • Create mapping/cellranger_atac_count component to align ATAC data to reference and count peaks

Issue ticket number and link

Contributes to #398

Checklist before requesting a review

  • I have performed a self-review of my code

  • Conforms to the Contributor's guide

  • Check the correct box. Does this PR contain:

    • Breaking changes
    • New functionality
    • Major changes
    • Minor changes
    • Documentation
    • Bug fixes
  • Proposed changes are described in the CHANGELOG.md

  • CI tests succeed!

@DriesSchaumont DriesSchaumont changed the base branch from main to develop March 25, 2024 10:40
Base automatically changed from develop to main June 12, 2024 14:20
@DriesSchaumont DriesSchaumont marked this pull request as draft August 7, 2024 06:22
@DriesSchaumont DriesSchaumont marked this pull request as ready for review August 23, 2024 08:40
Copy link
Member

@DriesSchaumont DriesSchaumont left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TYSM @VladimirShitov 🎉

@DriesSchaumont DriesSchaumont merged commit ab45cd1 into main Aug 23, 2024
@DriesSchaumont DriesSchaumont deleted the feature/atac-count branch August 23, 2024 09:13
dorien-er pushed a commit that referenced this pull request Aug 27, 2024
rcannood added a commit that referenced this pull request Aug 27, 2024
* bp cells regress out - wip

* install python

* update changelog

* blank lines

* install full python

* update python dependencies

* move python dependencies

* python alias

* python-as-python3

* python-is-python3

* add pytest

* update python environment

* add test and logging, remove clutter

* Apply suggestions from code review

Co-authored-by: Robrecht Cannoodt <[email protected]>

* address pr comments, add more unit tests

* address pr comments

* remove clutter

* remove clutter

* review code

* allow providing input layers for scanpy regress_out

* allow providing input layers for scanpy regress_out

* Add CellRanger ATAC count (#762)

* update changelog

* revert rebase changes

---------

Co-authored-by: Robrecht Cannoodt <[email protected]>
Co-authored-by: Vladimir Shitov <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants