Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add zypper keys command #163

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add zypper keys command #163

wants to merge 1 commit into from

Conversation

bzeller
Copy link
Contributor

@bzeller bzeller commented Mar 14, 2018 •
edited
Loading

Adds a zypper trusted key management API that allows the user to list/add/remove keys from the trusted keys database in zypper.

@bzeller bzeller force-pushed the keylist_cmd branch 3 times, most recently from ea5f89b to f26dd28 Compare March 15, 2018 09:59
@mlandres
Copy link
Member

A good start. 2 things immediately caught my eye:

  1. The commands probably don't need to launch the repos (refresh and loading the repo data). Initializing the Target should be enough.
  2. (nit-picky) The term subcommand is used for external programs just hooked into zypper (zypper help subcommand). zypper keys will become a (builtin) command :)

@bzeller bzeller force-pushed the keylist_cmd branch 3 times, most recently from 2dfb38d to 459c266 Compare March 16, 2018 15:49
@bzeller bzeller changed the title [WIP] Add zypper keys subcommand Add zypper keys subcommand Mar 16, 2018
bzeller
bzeller commented Mar 16, 2018
View reviewed changes
src/keys.cc Show resolved Hide resolved
bzeller
bzeller commented Mar 16, 2018
View reviewed changes
src/keys.cc Show resolved Hide resolved
@bzeller bzeller force-pushed the keylist_cmd branch 3 times, most recently from 3d97661 to 283c1e1 Compare March 23, 2018 10:03
mlandres
mlandres reviewed Sep 5, 2018
View reviewed changes
src/callbacks/keyring.h Outdated Show resolved Hide resolved
mlandres
mlandres requested changes Sep 5, 2018
View reviewed changes
src/Zypper.cc Outdated Show resolved Hide resolved
src/Zypper.cc Outdated Show resolved Hide resolved
src/Zypper.cc Outdated Show resolved Hide resolved
@bzeller bzeller force-pushed the keylist_cmd branch 2 times, most recently from 2b91475 to 284750f Compare January 14, 2019 08:56
@bzeller bzeller changed the title Add zypper keys subcommand Add zypper keys command Aug 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mlandres mlandres mlandres requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bzeller @mlandres