-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extending with custom manual instrumentation #5789
base: main
Are you sure you want to change the base?
Extending with custom manual instrumentation #5789
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks
content/en/docs/zero-code/java/spring-boot-starter/annotations.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Severin Neumann <[email protected]>
@svrnm can you check? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One more thing, I am not sure if api
is the right name for that, since we do not even mention "api" in the title, description, so either we do that, e.g. "Adding custom instrumentations with the API" or we rename the file to something like "extending-instrumentation.md" as well. wdyt?
it's API to separate it from annotations - which also extend |
@svrnm please check again |
--- | ||
title: Extending with custom manual instrumentation using the OpenTelemetry API | ||
linkTitle: Extending instrumentation | ||
description: Extending a Java agent with custom manual instrumentation. | ||
weight: 21 | ||
--- |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the title is now longer then the description, here is a proposal
--- | |
title: Extending with custom manual instrumentation using the OpenTelemetry API | |
linkTitle: Extending instrumentation | |
description: Extending a Java agent with custom manual instrumentation. | |
weight: 21 | |
--- | |
--- | |
title: Extending instrumentations with the API | |
linkTitle: Extend with the API | |
description: Use the OpenTelemetry API in combination with the Java agent to extend the automatically generated telemetry with custom instrumentations | |
weight: 21 | |
--- |
@chalin @jack-berg can you take a look as well?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Your proposal LGTM.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I adjusted slightly:
Use the OpenTelemetry API in combination with the Java agent to extend the automatically generated telemetry with custom spans and metrics
Co-authored-by: Severin Neumann <[email protected]>
Fixes #5713