Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Demo] Add info about React Native app #5704
base: main
Are you sure you want to change the base?
[Demo] Add info about React Native app #5704
Changes from 1 commit
9e14ab6
8304ec4
66ac20f
e41e5ea
60d5a21
61d5208
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
modelled from the Browser Instrumentation section in content/en/docs/demo/services/frontend.md, in that file a code snippet is included directly but given the TODOs in https://github.com/open-telemetry/opentelemetry-demo/blob/b4dc87ebeac93353106ebdbc7d29eb402e49eca8/src/reactnativeapp/hooks/useTracer.ts I thought it might be better to link out here instead, thoughts?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Personally I don't like doc pages that link to code snippets.
But this is my opinion, I'd love to hear what the @open-telemetry/docs-approvers have to say.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, let's not link out, especially to
blob/main
which may break at some point because the file was renamed.Let's have it like on the other pages and keep the source code, we (docs and demo maintainers) can discuss if we can make use of code-excerpts (See https://github.com/open-telemetry/opentelemetry.io/tree/main/tools) for demo source code as well to keep them in sync
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sounds good, updated here to include the snippet: e41e5ea