-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: no search entries found page (#5372) #5462
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this looks very good, thank you! One comment around the image, otherwise 👍
@svrnm Thank you very much for the feedback. |
@JennySimen we are currently discussion #5681 to enable the import of the 3rd party image, after this being resolved we should be able to merge your PR |
Thank you, looking forward to having the pr merged. |
@JennySimen apologies for the delay and for going back and forth. I agree with @chalin's point in this comment (#5681 (comment)) that we should avoid adding the overhead of an image that needs attribution and a license reference in our code. It's much easier in docs/blog text since we simply can put a copy right notice below the image. I copy the relevant part of the discussion:
the font awesome icons might be too small/minimalistic, I like the idea of the image, of course someone with a telescope not finding what they are looking for would be my preferred image. We could also use a variant of https://opentelemetry.io/homepage-hero-as-background_hu13043826424429285166.jpg WDYT? |
Closes #5372
This PR creates a new and better search result page when the is no seach found.
Steps to view work