-
Notifications
You must be signed in to change notification settings - Fork 452
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] BatchSpanProcessor with dedicated thread. #2456
base: main
Are you sure you want to change the base?
[WIP] BatchSpanProcessor with dedicated thread. #2456
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2456 +/- ##
=======================================
+ Coverage 76.9% 77.0% +0.1%
=======================================
Files 123 124 +1
Lines 22581 22843 +262
=======================================
+ Hits 17379 17609 +230
- Misses 5202 5234 +32 ☔ View full report in Codecov by Sentry. |
Copilot
AI
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
.recv_timeout(self.shutdown_timeout) | ||
.map_err(|_| TraceError::ExportTimedOut(self.shutdown_timeout))?; | ||
if let Some(handle) = self.handle.lock().unwrap().take() { | ||
handle.join().expect("Failed to join thread"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Using unwrap
on the mutex lock can potentially panic. Consider handling this more gracefully to avoid unexpected panics.
handle.join().expect("Failed to join thread"); | |
handle.join().expect("Failed to join thread after mutex lock"); |
Copilot is powered by AI, so mistakes are possible. Review output carefully before use.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice to have these basic issues getting caught :)
most stuff should work, apart from integration tests. Will be looking into it. Will make this ready for review after that. |
Fixes #2454
Design discussion issue (if applicable) #
Changes
WIP, tentative ready by Friday eod. changes consistent with #2436
Merge requirement checklist
CHANGELOG.md
files updated for non-trivial, user-facing changes