Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update specification to include development profiles #582

Merged
merged 6 commits into from
Sep 16, 2024

Conversation

dmathieu
Copy link
Member

This updates the OTLP specification to have appropriate mentions of the profiles signal (and mention it's experimental).

docs/specification.md Outdated Show resolved Hide resolved
@dmathieu dmathieu marked this pull request as ready for review September 10, 2024 12:28
@dmathieu dmathieu requested a review from a team September 10, 2024 12:28
@dmathieu
Copy link
Member Author

cc @open-telemetry/profiling-approvers @open-telemetry/profiling-maintainers @open-telemetry/profiling-triagers

Copy link
Member

@tigrannajaryan tigrannajaryan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just need to fix one round bracket.

docs/specification.md Outdated Show resolved Hide resolved
Co-authored-by: Tigran Najaryan <[email protected]>
Copy link
Member

@felixge felixge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks.

docs/specification.md Outdated Show resolved Hide resolved
@dmathieu dmathieu changed the title Update specification to include experimental profiles Update specification to include development profiles Sep 16, 2024
@dmathieu
Copy link
Member Author

We're waiting for this change to move forward with the collector OTLP receiver. Could we get more reviews/a merge?

@tigrannajaryan tigrannajaryan merged commit 50362a3 into open-telemetry:main Sep 16, 2024
15 checks passed
tigrannajaryan pushed a commit that referenced this pull request Sep 24, 2024
As discussed in #582 (comment), this renames the `v1experimental` version for profiles to `v1development`.

I've also taken this opportunity to update the versioning and stability link.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants