Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[next] merge changes from main #5275

Merged

Conversation

pichlermarc
Copy link
Member

@pichlermarc pichlermarc commented Dec 16, 2024

Important

This PR needs to be merged by a maintainer as we need to merge it non-squashed. Otherwise we'll have to do the same work again.

Updates next with the latest changes from main, all changes here are pre-reviewed already

@pichlermarc pichlermarc requested a review from a team as a code owner December 16, 2024 17:28
Copy link

codecov bot commented Dec 16, 2024

Codecov Report

Attention: Patch coverage is 99.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 94.63%. Comparing base (47212bb) to head (4179ddb).
Report is 23 commits behind head on next.

Files with missing lines Patch % Lines
...imental/packages/opentelemetry-sdk-node/src/sdk.ts 95.74% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             next    #5275      +/-   ##
==========================================
+ Coverage   94.56%   94.63%   +0.06%     
==========================================
  Files         316      323       +7     
  Lines        8037     8084      +47     
  Branches     1628     1643      +15     
==========================================
+ Hits         7600     7650      +50     
+ Misses        437      434       -3     
Files with missing lines Coverage Δ
...l/packages/otlp-transformer/src/common/internal.ts 100.00% <100.00%> (ø)
...ntal/packages/otlp-transformer/src/common/utils.ts 100.00% <ø> (ø)
...ckages/otlp-transformer/src/logs/internal-types.ts 100.00% <ø> (ø)
...tal/packages/otlp-transformer/src/logs/internal.ts 100.00% <100.00%> (ø)
...l/packages/otlp-transformer/src/logs/json/index.ts 100.00% <100.00%> (ø)
...al/packages/otlp-transformer/src/logs/json/logs.ts 100.00% <100.00%> (ø)
...ckages/otlp-transformer/src/logs/protobuf/index.ts 100.00% <100.00%> (ø)
...ackages/otlp-transformer/src/logs/protobuf/logs.ts 100.00% <100.00%> (ø)
...ges/otlp-transformer/src/metrics/internal-types.ts 100.00% <ø> (ø)
.../packages/otlp-transformer/src/metrics/internal.ts 100.00% <100.00%> (ø)
... and 14 more

... and 3 files with indirect coverage changes

@pichlermarc pichlermarc added the target:next-major-release This PR targets the next major release (`next` branch) label Dec 17, 2024
@chancancode
Copy link
Contributor

This probably should be updated to pull in 8ab52d5, currently any PR targeting next will fail without it. #5280 would be nice to have as well if it makes it in time for the release.

@pichlermarc
Copy link
Member Author

This probably should be updated to pull in 8ab52d5, currently any PR targeting next will fail without it. #5280 would be nice to have as well if it makes it in time for the release.

Done 🙂

@pichlermarc pichlermarc merged commit b8d7966 into open-telemetry:next Dec 18, 2024
18 checks passed
@pichlermarc pichlermarc deleted the next-main-2024-12-16 branch December 18, 2024 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
target:next-major-release This PR targets the next major release (`next` branch)
Projects
None yet
Development

Successfully merging this pull request may close these issues.