feat(jaeger-propagator): propagate/extract baggage #2137 #2158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vmarchaud
requested review from
Flarna,
johnbley,
legendecas,
markwolff,
mayurkale22,
mwear,
naseemkullah,
obecny and
OlivierAlbertini
as code owners
Codecov Report
@@ Coverage Diff @@
## main #2158 +/- ##
==========================================
+ Coverage 92.82% 92.83% +0.01%
==========================================
Files 139 139
Lines 5003 5024 +21
Branches 1030 1035 +5
==========================================
+ Hits 4644 4664 +20
- Misses 359 360 +1
|
Flarna
reviewed
Apr 26, 2021
packages/opentelemetry-propagator-jaeger/src/JaegerHttpTracePropagator.ts
Outdated
Show resolved
Hide resolved
Flarna
reviewed
Apr 26, 2021
packages/opentelemetry-propagator-jaeger/src/JaegerHttpTracePropagator.ts
Outdated
Show resolved
Hide resolved
Flarna
reviewed
Apr 26, 2021
packages/opentelemetry-propagator-jaeger/src/JaegerHttpTracePropagator.ts
Outdated
Show resolved
Hide resolved
vmarchaud
force-pushed
the
jeager-propagate-baggage
branch
from
09c9302 to
00eca4d
Compare
|
I've rebased and addressed comments |
vmarchaud
force-pushed
the
jeager-propagate-baggage
branch
from
00eca4d to
bc560ac
Compare
obecny
approved these changes
May 3, 2021
packages/opentelemetry-propagator-jaeger/src/JaegerHttpTracePropagator.ts
Outdated
Show resolved
Hide resolved
dyladan
approved these changes
May 3, 2021
|
@vmarchaud after conflicts and @obecny's nit you can merge |
|
@vmarchaud I think you can resolve conflicts and merge it |
|
i think he mentioned in SIG he will have time to work on otel this weekend. |
vmarchaud
force-pushed
the
jeager-propagate-baggage
branch
from
bc560ac to
067266f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Spec: https://www.jaegertracing.io/docs/1.21/client-libraries/#propagation-format
I checked and the spec doesn't say if we should support both
HTTP_HEADERSandTEXT_MAPencoding but since this propagator is mostly used for http propagation, i'm not sure how we should do that.There is already a discussion in the java SIG for this (open-telemetry/opentelemetry-java#2032) and its apparently waiting for the spec to be solved. I think we should wait for spec to know if we need both or not
Fixes #2137