Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Prototype] How to support complex attributes in logs/events? (Option B) #6959

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

trask
Copy link
Member

@trask trask commented Dec 16, 2024

Prototype for open-telemetry/opentelemetry-specification#4334

See also

Looking for feedback from @open-telemetry/java-approvers on whether evolving in this way seems reasonable, or if there is a different approach you would prefer in order to support complex attributes on logs/events.

@@ -115,4 +115,8 @@ static Value<List<KeyValue>> of(Map<String, Value<?>> value) {
*/
// TODO(jack-berg): Should this be a JSON encoding?
String asString();

static ValueBuilder builder() {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is specifically for building "maps"

another option is in #6761 that has separate map and list builders:

https://github.com/open-telemetry/opentelemetry-java/pull/6761/files#diff-11421657bbb9763b8bd1579fe3bc147d5955abc85a01a94eb567f641cdbb17a7R87-R93

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant