Remove -alpha artifacts from runtime classpath of stable components #6944
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6944 +/- ##
============================================
- Coverage 90.09% 90.01% -0.09%
- Complexity 6601 6630 +29
============================================
Files 730 746 +16
Lines 19843 19982 +139
Branches 1955 1955
============================================
+ Hits 17877 17986 +109
- Misses 1371 1401 +30
Partials 595 595 ☔ View full report in Codecov by Sentry. |
jack-berg
commented
Dec 11, 2024
| "-Xlint:-options", | ||
| // Fail build on any warning | ||
| "-Werror", | ||
| "-Xlint:-options" |
jack-berg
commented
Dec 11, 2024
| @@ -16,7 +16,6 @@ dependencies { | |||
| protoSource("io.opentelemetry.proto:opentelemetry-proto:${versions["io.opentelemetry.proto"]}") | |||
|
|
|||
| api(project(":exporters:common")) | |||
| implementation(project(":api:incubator")) | |||
There was a problem hiding this comment.
Unused now that Value is stable.
jack-berg
commented
Dec 11, 2024
| return NOOP_METER.counterBuilder(NOOP_INSTRUMENT_NAME); | ||
| } | ||
| try { | ||
| Class.forName("io.opentelemetry.api.incubator.metrics.ExtendedLongCounter"); |
There was a problem hiding this comment.
Was fast and loose with this. Before considering merging, would refactor to call this once and cache the result.
trask
reviewed
Dec 11, 2024
Comment on lines
+39
to
+45
| try { | ||
| Class.forName("io.opentelemetry.api.incubator.trace.ExtendedTracer"); | ||
| return IncubatingUtil.createIncubatingTracer( | ||
| sharedState, instrumentationScopeInfo, tracerConfig); | ||
| } catch (Exception e) { | ||
| return new SdkTracer(sharedState, instrumentationScopeInfo, tracerConfig); | ||
| } |
There was a problem hiding this comment.
maybe?
Suggested change
| try { | |
| Class.forName("io.opentelemetry.api.incubator.trace.ExtendedTracer"); | |
| return IncubatingUtil.createIncubatingTracer( | |
| sharedState, instrumentationScopeInfo, tracerConfig); | |
| } catch (Exception e) { | |
| return new SdkTracer(sharedState, instrumentationScopeInfo, tracerConfig); | |
| } | |
| if (IncubatingUtil.isPresent()) { | |
| return IncubatingUtil.createIncubatingTracer( | |
| sharedState, instrumentationScopeInfo, tracerConfig); | |
| } else { | |
| return new SdkTracer(sharedState, instrumentationScopeInfo, tracerConfig); | |
| } |
There was a problem hiding this comment.
Yup yup that's my plan
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sketch out what it looks like to remove
-alphaartifacts (especiallyopentelemetry-api-incubator) from the runtime classpath of stable components.Approach is:
implementationtocompileOnlydependencies-alphaartifact is present on classpath (i.e. provided by the user) and toggle behavior based on whether it is or isnt-alphaartifacts are not provided by user, make sure main test suite runs without-alphaartifacts.-alphaartifacts are present, introduce new test suite including the-alphaartifacts, and test the impacted behaviorThis is related to a possible adjustment of our versioning guidelines. If we went in this direction, a user adding only stable dependencies could always run
./gradlew dependenciesand will not see any-alphaartifacts on the runtime classpath.