Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated ExecutorServiceSpanProcessor #3864

Merged
merged 2 commits into from
Nov 16, 2021

Conversation

anuraaga
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Nov 12, 2021

Codecov Report

Merging #3864 (62a62ed) into main (82e2bc2) will increase coverage by 0.28%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##               main    #3864      +/-   ##
============================================
+ Coverage     89.70%   89.99%   +0.28%     
+ Complexity     4230     4170      -60     
============================================
  Files           504      500       -4     
  Lines         13059    12726     -333     
  Branches       1274     1220      -54     
============================================
- Hits          11715    11453     -262     
+ Misses          915      890      -25     
+ Partials        429      383      -46     
Impacted Files Coverage Δ
...entelemetry/exporter/jaeger/PostSpansResponse.java 0.00% <0.00%> (-100.00%) ⬇️
...entelemetry/exporter/otlp/internal/Serializer.java 75.00% <0.00%> (-9.06%) ⬇️
...exporter/jaeger/MarshalerCollectorServiceGrpc.java 85.71% <0.00%> (-4.77%) ⬇️
...try/sdk/metrics/data/DoubleHistogramPointData.java 96.15% <0.00%> (-0.15%) ⬇️
...k/metrics/internal/aggregator/MetricDataUtils.java 100.00% <0.00%> (ø)
.../internal/metrics/HistogramDataPointMarshaler.java 100.00% <0.00%> (ø)
...xtension/incubator/trace/data/SpanDataBuilder.java
...nsion/incubator/trace/data/DelegatingSpanData.java
.../opentelemetry/sdk/internal/PrimitiveLongList.java 100.00% <0.00%> (ø)
...io/opentelemetry/sdk/metrics/SdkDoubleCounter.java 100.00% <0.00%> (+2.94%) ⬆️
... and 12 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 82e2bc2...62a62ed. Read the comment docs.

@jack-berg
Copy link
Member

There were a bunch of supporting test and JMH classes that were committed with ExecutorServiceSpanProcessor. See original pr #3036.

I also didn't see this commit from you and had done something similar, but have since reverted the commit. Checkout this commit for the other stuff you can remove.

@anuraaga
Copy link
Contributor Author

Thanks for the pointer @jack-berg - looks like we have similar tests in the trace module so went ahead and deleted

@anuraaga anuraaga merged commit 3190325 into open-telemetry:main Nov 16, 2021
This was referenced Dec 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants