sdk/trace: Allow errors supplied to RecordError to supply values for semconv.ExceptionType
#5760
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tmc
requested review from
MrAlias,
XSAM,
dashpole,
MadVikingGod,
pellared,
hanyuancheung and
dmathieu
as code owners
tmc
changed the title
semconv.ExceptionTypesemconv.ExceptionType
dmathieu
reviewed
Sep 6, 2024
|
This design does not look to be accepted. |
|
@tmc, do you plan to move this forward or can we close the PR? |
|
I haven't had time to attend a meeting to discuss this change but still believe it improves the quality of this library for Go developer/systems administrators. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds and uses an interface when determining the appropriate representation for the error that is supplied to
semconv.ExceptionType.Addresses part of #2591