otelhttptrace: handle missing getconn hook without panic

We have many reports that end() gets called without the span being defined in start() and causes a panic. Signed-off-by: Tonis Tiigi <[email protected]>
open-telemetry · Feb 27, 2024 · d12420f · d12420f
1 parent 45226f8
commit d12420f
Showing 1 changed file with 4 additions and 0 deletions.
diff --git a/instrumentation/net/http/httptrace/otelhttptrace/clienttrace.go b/instrumentation/net/http/httptrace/otelhttptrace/clienttrace.go
@@ -226,6 +226,10 @@ func (ct *clientTracer) start(hook, spanName string, attrs ...attribute.KeyValue
 
 func (ct *clientTracer) end(hook string, err error, attrs ...attribute.KeyValue) {
 	if !ct.useSpans {
+		// sometimes end may be called without previous start
+		if ct.root == nil {
+			ct.root = trace.SpanFromContext(ct.Context)
+		}
 		if err != nil {
 			attrs = append(attrs, attribute.String(hook+".error", err.Error()))
 		}