Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix python3.12 on ubuntu x86-64 #284

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

gnurizen
Copy link
Contributor

@gnurizen gnurizen commented Dec 17, 2024

Fix from: DataDog@630fd97

This error occurs on stock python 3.12 on ubuntu x86-64.

Fixes issue: #251

Fix from: DataDog@630fd97

This error occurs on stock python 3.12 on ubuntu x86-64.
@gnurizen gnurizen requested review from a team as code owners December 17, 2024 14:24
@Gandem
Copy link
Contributor

Gandem commented Dec 17, 2024

Hey @gnurizen 👋 The commit I authored in DataDog@630fd97 unfortunately doesn't fully fix #251.

I think we should consider the alternative described in:

b. Add more logic in disassembly code: Add logic in decode_amd64.c to take into account variables in temporary registers, and the case where %rdi is populated via mov then add. We could potentially fix both issues at the cost of additionally complexity.

So we better cover all the edge cases discussed in that issue (didn't get around to implementing this yet though).

Additionally, as far as I can tell, the packaged python in ubuntu is compiled with --enable-optimizations, --with-lto, so this shouldn't impact stock python 3.12 on ubuntu x86-64. Do you have more information on how you reproduced this? We might have missed something on the original issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants