Use clang-17 for building binary #270
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
christos68k
reviewed
Dec 9, 2024
There was a problem hiding this comment.
Hi @mchataigner, can you also fix the tests? It seems you just need to update the GH workflow and introduce clang-19.
|
Comparison of eBPF artifacts size clang-16 clang-17 clang-18 |
mchataigner
force-pushed
the
fix_docker_build
branch
from
40479f9 to
02807d8
Compare
mchataigner
changed the title
|
Ok, switching to clang-18 because 19 is not available by default on ubuntu 24.04 github action runner. |
|
The 4.19 and 5.4 ebpf verifiers are too picky for clang-18 code :| |
mchataigner
force-pushed
the
fix_docker_build
branch
from
02807d8 to
84e774d
Compare
|
Ok, then I’m trying Clang 17 :) |
mchataigner
changed the title
mchataigner
force-pushed
the
fix_docker_build
branch
2 times, most recently
from
3ca8442 to
e98300e
Compare
|
ok, it seems to work with clang 17 |
rockdaboot
approved these changes
Dec 10, 2024
|
https://apt.llvm.org/ may be worth considering automatic install script from llvm and still using clang-16 |
christos68k
reviewed
Dec 10, 2024
For some reason, clang-16 is not available anymore on debian testing. Switching to clang 17 (available in both ubuntu 24.04 github runner and debian testing) unblocks the build. - Clang 19 was not available in ubuntu 24.04 github runner - Clang 18 broke tests with kernels 4.19.314 and 5.4.276
mchataigner
force-pushed
the
fix_docker_build
branch
from
e98300e to
c066dc3
Compare
AMD64: perf_event/unwind_dotnet has 3463 instructions perf_event/unwind_hotspot has 3266 instructions tracepoint/sched/sched_switch has 1160 instructions perf_event/unwind_stop has 445 instructions perf_event/native_tracer_entry has 431 instructions perf_event/unwind_native has 4002 instructions perf_event/unwind_perl has 2585 instructions perf_event/unwind_php has 2523 instructions perf_event/unwind_python has 3654 instructions perf_event/unwind_ruby has 2927 instructions tracepoint/sched/sched_process_exit has 111 instructions tracepoint/syscalls/sys_enter_bpf has 25 instructions raw_tracepoint/sys_enter has 29 instructions perf_event/unwind_v8 has 3312 instructions Total instructions: 27933 ARM64: I had to run `make agent TARGET_ARCH=arm64` twice: ```error: Invalid record (Producer: 'LLVM19.1.4' Reader: 'LLVM17.0.6')```
|
I had to run |
christos68k
reviewed
Dec 11, 2024
There was a problem hiding this comment.
This is now essentially an empty file so something went wrong on your end. I pushed a branch that has the ARM64 artifact compiled with clang-17 through the docker image. Feel free to copy it from there.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some reason, clang-16 is not available anymore on debian testing.
Switching to clang 17 (available in both ubuntu 24.04 github runner and debian testing) unblocks the build.