Fix tag_suffix for accounting service #1848
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Helm chart generates a kubernetes manifest that expects the suffix of the account service's image to be
accountingservice
.opentelemetry-demo/kubernetes/opentelemetry-demo.yaml
Lines 9533 to 9535 in fa7847e
Few options to fix this:
I'd be happy to follow up on whatever solution people would prefer.
If people like the solution in this PR, I think it would also make sense to change the directory name and all contained files back toaccountingservice
for consistency - e.g.,/src/accounting
becomes/src/accountingservice
. Thoughts?I see now that there is an effort to remove the term
service
from the names of the services in #1788. I recommend leaving the tag_suffix for services untouched for now.