Add logs scraper in factory #11822
Open
Add logs scraper in factory #11822
+69
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #11822 +/- ##
=======================================
Coverage 91.62% 91.62%
=======================================
Files 447 447
Lines 23739 23751 +12
=======================================
+ Hits 21751 21763 +12
Misses 1613 1613
Partials 375 375 ☔ View full report in Codecov by Sentry. |
bogdandrutu
approved these changes
Dec 9, 2024
|
@bogdandrutu @evan-bradley Could we please add |
atoulme
reviewed
Dec 11, 2024
scraper/factory.go
Outdated
| // CreateLogs creates a Logs scraper based on this config. | ||
| // If the scraper type does not support logs, | ||
| // this function returns the error [pipeline.ErrSignalNotSupported]. | ||
| // Implementers can assume `next` is never nil. |
There was a problem hiding this comment.
Suggested change
| // Implementers can assume `next` is never nil. |
There was a problem hiding this comment.
@atoulme Good catch! I think this line is copied from somewhere. Removed it.
atoulme
approved these changes
Dec 11, 2024
songy23
added
the
ready-to-merge
|
ping |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add scraper for logs(#11799) in the factory
Link to tracking issue
Relates to #11238 , #11799
Testing
Added
Documentation
Updated the previous change log file