Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: run linux package tests nightly against latest contrib main [new] #762

Open
wants to merge 11 commits into
base: main
Choose a base branch
from

Conversation

mowies
Copy link
Member

@mowies mowies commented Dec 5, 2024

Supersedes #760

Changes compared to the previously reverted PR:

  • adapted the base-release.yaml to the changed gorelease setup for otelcol-contrib

Copied description from old PR:

This PR enables nightly testing of the otelcol-contrib linux packages based on the latest main branch version of otelcol-contrib built in https://github.com/open-telemetry/opentelemetry-collector-contrib.
This change was made possible by splitting the otelcol-contrib gorelease config into 2 separate files, one for building and one for packaging/archives/docker images/etc.
(The split goreleaser build is a goreleaser pro feature)

Using the split building approach was the only viable option to achieve this. I did lots of research on this, it was talked about in the Collector SIG meeting and I also asked the GoReleaser folks for their help.

Consequences of this change:

  • better testing
  • slightly less maintainability of the goreleaser files and generator code for otelcol-contrib since they have special handling now

Fixes #659

@mowies
Copy link
Member Author

mowies commented Dec 5, 2024

I ran a successful test release on my fork. Workflow run links and test release below:

@mowies mowies marked this pull request as ready for review December 5, 2024 09:28
@mowies mowies requested a review from a team as a code owner December 5, 2024 09:28
@mowies mowies requested a review from MovieStoreGuy December 5, 2024 09:28
@mx-psi
Copy link
Member

mx-psi commented Dec 5, 2024

For my understanding I would like to know what parts were not testable without the pro key

@mowies
Copy link
Member Author

mowies commented Dec 5, 2024

We use quite a few pro-only features and I specifically made use of a new one in my PR: Importing of prebuilt binaries. Specifically, I either build the otelcol-contrib from scratch or I download the prebuilt binary from the contrib repo and use it.

Other pro-only features we use (probably not a complete list):

@mowies
Copy link
Member Author

mowies commented Dec 5, 2024

In this case testing was much easier with a pro key to be able to actually run a close-to-reality version of the setup from start (pushing a tag) to finish (the actual github release).

@mowies mowies requested review from a team as code owners December 11, 2024 09:34
@mowies
Copy link
Member Author

mowies commented Dec 11, 2024

after a bit of time in rebase-hell this PR should be ready again for merging 🚀

@mx-psi
Copy link
Member

mx-psi commented Dec 11, 2024

@TylerHelmuth @atoulme can you take a look at this?

Copy link
Member

@mx-psi mx-psi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-approving

@mowies
Copy link
Member Author

mowies commented Dec 16, 2024

i had to downgrade the package tests from ubuntu-latest (as of a few days ago 24.04) to 22.04 because of some issue that i can't figure out right now (see this run). i can file a separate issue for that, but i think it's mostly related to the container setup of the package tests

@mowies mowies mentioned this pull request Dec 17, 2024
@mx-psi
Copy link
Member

mx-psi commented Dec 17, 2024

@atoulme will merge after this release is done if there are no further comments

Signed-off-by: Moritz Wiesinger <[email protected]>
# Conflicts:
#	cmd/goreleaser/internal/configure.go
@mx-psi mx-psi enabled auto-merge December 18, 2024 15:28
auto-merge was automatically disabled December 18, 2024 15:33

Head branch was pushed to by a user without write access

Signed-off-by: Moritz Wiesinger <[email protected]>
@mowies
Copy link
Member Author

mowies commented Dec 18, 2024

ok i manually reverted the previous rebase since #784 happened. PR should be ready again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add nightly linux package tests
5 participants