-
Notifications
You must be signed in to change notification settings - Fork 165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: run linux package tests nightly against latest contrib main [new] #762
base: main
Are you sure you want to change the base?
test: run linux package tests nightly against latest contrib main [new] #762
Conversation
dcb3755
to
92e0758
Compare
For my understanding I would like to know what parts were not testable without the pro key |
We use quite a few pro-only features and I specifically made use of a new one in my PR: Importing of prebuilt binaries. Specifically, I either build the otelcol-contrib from scratch or I download the prebuilt binary from the contrib repo and use it. Other pro-only features we use (probably not a complete list): |
In this case testing was much easier with a pro key to be able to actually run a close-to-reality version of the setup from start (pushing a tag) to finish (the actual github release). |
ad3bb50
to
1ba3d1a
Compare
da8f33a
to
e8974fd
Compare
after a bit of time in rebase-hell this PR should be ready again for merging 🚀 |
@TylerHelmuth @atoulme can you take a look at this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Re-approving
Signed-off-by: Moritz Wiesinger <[email protected]>
e8974fd
to
d4f0414
Compare
Signed-off-by: Moritz Wiesinger <[email protected]>
i had to downgrade the package tests from ubuntu-latest (as of a few days ago 24.04) to 22.04 because of some issue that i can't figure out right now (see this run). i can file a separate issue for that, but i think it's mostly related to the container setup of the package tests |
@atoulme will merge after this release is done if there are no further comments |
Signed-off-by: Moritz Wiesinger <[email protected]>
# Conflicts: # cmd/goreleaser/internal/configure.go
Signed-off-by: Moritz Wiesinger <[email protected]>
Head branch was pushed to by a user without write access
Signed-off-by: Moritz Wiesinger <[email protected]>
ok i manually reverted the previous rebase since #784 happened. PR should be ready again. |
Supersedes #760
Changes compared to the previously reverted PR:
base-release.yaml
to the changed gorelease setup for otelcol-contribCopied description from old PR:
This PR enables nightly testing of the otelcol-contrib linux packages based on the latest main branch version of otelcol-contrib built in https://github.com/open-telemetry/opentelemetry-collector-contrib.
This change was made possible by splitting the otelcol-contrib gorelease config into 2 separate files, one for building and one for packaging/archives/docker images/etc.
(The split goreleaser build is a goreleaser pro feature)
Using the split building approach was the only viable option to achieve this. I did lots of research on this, it was talked about in the Collector SIG meeting and I also asked the GoReleaser folks for their help.
Consequences of this change:
Fixes #659