[receiver/gitlab] add tracing via webhook skeleton #36838
Draft
+1,181
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adrielp
reviewed
Dec 15, 2024
adrielp
reviewed
Dec 15, 2024
adrielp
reviewed
Dec 16, 2024
receiver/gitlabreceiver/config.go
Outdated
| Secret string `mapstructure:"secret"` // secret for webhook | ||
| } | ||
|
|
||
| type RequiredHeader struct { |
There was a problem hiding this comment.
I've been thinking about this for the GitHub receiver as well, but I think this should be converted to RequiredHeaders of map[string]string so that a user can set any set of headers that are required. The main one that would be useful for GitLab would be X-Gitlab-Instance. But if a user has a WAF sitting in front of the receiver (which they should anyway for public traffic) then they can set additional headers of their own choosing.
For the other headers listed in the doc, I think we should map these internal to the receiver.
adrielp
reviewed
Dec 16, 2024
adrielp
reviewed
Dec 16, 2024
adrielp
reviewed
Dec 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds the structure and trace skeleton for a new and already accepted Gitlabreceiver. (thanks @atoulme for sponsoring this!)
The Gitlabreceiver aligns very closely with the Githubreceiver and this PR mostly mirrors the change from this PR: #36632
I'm working together with @adrielp on building out the Gitlabreceiver. More PRs to introduce metrics and actual tracing functionality are about to follow with subsequent PRs.
Link to tracking issue
#35207
Testing
Added basic tests and built the component to test that the health check endpoint, when tracing is enabled, operates correctly.
Documentation
Docs how to configure the Gitlabreceiver via webhooks have been added. While the Gitlabreceiver can be configured after this PR, it will not actually do anything since it is under development and just the skeleton PR.