[receiver/libhoney] Libhoney receiver log signal #36827
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
receiver/libhoneyreceiver/encoder.go
Outdated
There was a problem hiding this comment.
Can this be moved to internal?
There was a problem hiding this comment.
We need to add some unit tests for our parsing logic.
There was a problem hiding this comment.
I put the tests in the parsing package. Do we need more up at this level?
There was a problem hiding this comment.
Ya we need a config_test.go and factory_test.go and a receiver_test.go. The datadogreceiver and splunkhecreceiver are good examples
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is the implementation for the logs signal related to the new libhoney receiver.
Link to tracking issue
#36693