s3 exporter: exporter improvements and migration v2 aws sdk #36698
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change migrates the exporter to use sdk v2 while also providing some code improvements.
MovieStoreGuy
force-pushed
the
msg/migrate-to-sdk-v2
branch
from
18cb087 to
eecb3a0
Compare
|
Is action for #36699 |
atoulme
reviewed
Dec 6, 2024
atoulme
reviewed
Dec 6, 2024
atoulme
approved these changes
Dec 6, 2024
atoulme
approved these changes
Dec 6, 2024
ZenoCC-Peng
pushed a commit
to ZenoCC-Peng/opentelemetry-collector-contrib
that referenced
this pull request
Dec 6, 2024
…emetry#36698) #### Description With the annoucement of [eol](https://aws.amazon.com/blogs/developer/announcing-end-of-support-for-aws-sdk-for-go-v1-on-july-31-2025/) for the aws v1 sdk, this will give the project time to adopt the latest SDK to provide feedback. Furthermore, there is also minor code improvements to improve maintainability. #### Link to tracking issue <!--Describe what testing was performed and which tests were added.--> #### Testing Included unit tests as part of the changes. <!--Describe the documentation added.--> #### Documentation This is mostly a behaviourally change, and shouldn't have any user impact but it is worth calling out.
sbylica-splunk
pushed a commit
to sbylica-splunk/opentelemetry-collector-contrib
that referenced
this pull request
Dec 17, 2024
…emetry#36698) #### Description With the annoucement of [eol](https://aws.amazon.com/blogs/developer/announcing-end-of-support-for-aws-sdk-for-go-v1-on-july-31-2025/) for the aws v1 sdk, this will give the project time to adopt the latest SDK to provide feedback. Furthermore, there is also minor code improvements to improve maintainability. #### Link to tracking issue <!--Describe what testing was performed and which tests were added.--> #### Testing Included unit tests as part of the changes. <!--Describe the documentation added.--> #### Documentation This is mostly a behaviourally change, and shouldn't have any user impact but it is worth calling out.
|
I recently upgraded my opentelemetry collector and ran across an issue with the new v2 aws sdk along with a google cloud storage using S3 compatibility API. The issue is described here: aws/aws-sdk-go-v2#1816 and also here: https://stackoverflow.com/questions/73717477/gcp-cloud-storage-golang-aws-sdk2-upload-file-with-s3-interoperability-creds It seems the sdk v2 is no longer compatible with GCS at least without injecting some middleware code to mangle some headers. Would you consider adding this "workaround" or is it out of scope ? It seems there is no native GCS exporter equivalent to awss3 exporter. |
|
Moved to new issue #36885 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
With the annoucement of eol for the aws v1 sdk, this will give the project time to adopt the latest SDK to provide feedback.
Furthermore, there is also minor code improvements to improve maintainability.
Link to tracking issue
Testing
Included unit tests as part of the changes.
Documentation
This is mostly a behaviourally change, and shouldn't have any user impact but it is worth calling out.