Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[prometheusreceiver] Make use of created timestamp from prometheus #36660

Draft
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

bacherfl
Copy link
Contributor

@bacherfl bacherfl commented Dec 4, 2024

Description

This PR implements the AppendCTZeroSample and AppendHistogramCTZeroSample methods which can be called by prometheus to pass through the creation timestamp of a metric

Link to tracking issue

Fixes #36473

Testing

Added unit tests

@github-actions github-actions bot added the receiver/prometheus Prometheus receiver label Dec 4, 2024
Signed-off-by: Florian Bacher <[email protected]>
Signed-off-by: Florian Bacher <[email protected]>
@dashpole
Copy link
Contributor

dashpole commented Dec 4, 2024

I think we might need the prometheus update for this to work: #36642

@bacherfl
Copy link
Contributor Author

bacherfl commented Dec 5, 2024

I think we might need the prometheus update for this to work: #36642

thanks for the link to the PR - I was wondering if I should also include the dependency update in my PR but in this case I will wait for the dependency update PR to get merged.

One other thing: As of now, it seems like the CreatedTimestamp() method is only implemented for the openmetrics parser, but not for the prometheus parser - So I think we need to wait with removing the receiver.prometheusreceiver.UseCreatedMetric and keep the code related to that for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
receiver/prometheus Prometheus receiver
Projects
None yet
Development

Successfully merging this pull request may close these issues.

prometheusreceiver: Make use of created timestamp from prometheus
2 participants