fix: Add keyboard support to CardHorizontalBarChart and InfoTooltip #4165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mohammedfirdouss
requested review from
zeucapua,
brandonroberts and
nickytonline
as code owners
❌ Deploy Preview for oss-insights failed. Why did it fail? →
|
✅ Deploy Preview for design-insights ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
nickytonline
requested changes
Oct 15, 2024
components/molecules/CardHorizontalBarChart/card-horizontal-bar-chart.tsx
Outdated
Show resolved
Hide resolved
Co-authored-by: Nick Taylor <[email protected]>
nickytonline
requested changes
Oct 17, 2024
components/molecules/CardHorizontalBarChart/card-horizontal-bar-chart.tsx
Outdated
Show resolved
Hide resolved
Co-authored-by: Nick Taylor <[email protected]>
Co-authored-by: Nick Taylor <[email protected]>
nickytonline
requested changes
Oct 21, 2024
components/molecules/CardHorizontalBarChart/card-horizontal-bar-chart.tsx
Outdated
Show resolved
Hide resolved
|
Hi @Firdous2307, just seeing if you're blocked on anything. No rush on this, just checking in. |
@nickytonline Everything is good, I just took a little break, thanks for checking in. |
nickytonline
requested changes
Oct 31, 2024
|
@nickytonline I mistakenly closed the main repository, thinking the changes were already merged. Apologies for the inconvenience. I'll redo the necessary steps, which should be fewer now since we’ve already addressed the main point. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes accessibility issues in the CardHorizontalBarChart and InfoTooltip components. It addresses the
jsx-a11y/mouse-events-have-key-eventswarnings and improves keyboard navigation support.Related Tickets & Documents
Fixes #4133
Mobile & Desktop Screenshots/Recordings
N/A (No visual changes, only accessibility improvements)
Steps to QA
Tier (staff will fill in)
[optional] What gif best describes this PR or how it makes you feel?