Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: repository page width overflow #4051

Merged
merged 4 commits into from
Aug 28, 2024
Merged

Conversation

zeucapua
Copy link
Contributor

Description

Fixes the repo page overflowing on mobile view. Changes were mainly to the 'controls' section of the page (Add to buttons, share, and day range picker) for both mobile and desktop views.

Related Tickets & Documents

Closes #4050

Mobile & Desktop Screenshots/Recordings

Before

image

After

image

Steps to QA

  1. Go to repository page on mobile
  2. See the width is within screen width
  3. Use desktop view to ensure no changes were made to its width

Tier (staff will fill in)

  • Tier 1
  • Tier 2
  • Tier 3
  • Tier 4

[optional] What gif best describes this PR or how it makes you feel?

@zeucapua zeucapua requested a review from a team August 27, 2024 21:34
Copy link

netlify bot commented Aug 27, 2024

Deploy Preview for oss-insights ready!

Name Link
🔨 Latest commit ffce382
🔍 Latest deploy log https://app.netlify.com/sites/oss-insights/deploys/66ce7a2d4628d40008cb507e
😎 Deploy Preview https://deploy-preview-4051--oss-insights.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Aug 27, 2024

Deploy Preview for design-insights ready!

Name Link
🔨 Latest commit ffce382
🔍 Latest deploy log https://app.netlify.com/sites/design-insights/deploys/66ce7a2d4e9c2c00082d0c29
😎 Deploy Preview https://deploy-preview-4051--design-insights.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@nickytonline nickytonline left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These buttons need to be the same width for all screen sizes.

PR

CleanShot 2024-08-27 at 17 56 10

Prod

CleanShot 2024-08-27 at 17 57 02

Aside from that, everything else is good.

@zeucapua
Copy link
Contributor Author

Button widths are the same now cc @nickytonline

image

Copy link
Member

@nickytonline nickytonline left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@brandonroberts brandonroberts added this pull request to the merge queue Aug 28, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Aug 28, 2024
@nickytonline nickytonline added this pull request to the merge queue Aug 28, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Aug 28, 2024
@nickytonline nickytonline added this pull request to the merge queue Aug 28, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Aug 28, 2024
@zeucapua zeucapua added this pull request to the merge queue Aug 28, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Aug 28, 2024
@nickytonline nickytonline added this pull request to the merge queue Aug 28, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Aug 28, 2024
@zeucapua zeucapua added this pull request to the merge queue Aug 28, 2024
Merged via the queue into beta with commit b827d26 Aug 28, 2024
13 checks passed
@zeucapua zeucapua deleted the fix/repo-page-mobile-width branch August 28, 2024 02:33
open-sauced bot pushed a commit that referenced this pull request Aug 28, 2024
## [2.61.0-beta.8](v2.61.0-beta.7...v2.61.0-beta.8) (2024-08-28)

### 🐛 Bug Fixes

* repository page width overflow ([#4051](#4051)) ([b827d26](b827d26))
open-sauced bot pushed a commit that referenced this pull request Aug 29, 2024
## [2.61.0](v2.60.0...v2.61.0) (2024-08-29)

### 🍕 Features

* add contributor confidence to repository table ([#4038](#4038)) ([6f510cb](6f510cb))
* Add contributor's insight on the workspace. ([#4060](#4060)) ([7c4b60b](7c4b60b))
* copy repo page `ForksChart` as image ([#4036](#4036)) ([d30beff](d30beff))
* copy repo page `StarsChart` as image  ([#4035](#4035)) ([933bb2c](933bb2c))
* copy repo page Contributors chart as image ([#4025](#4025)) ([581497e](581497e))
* copy repo page Issues chart as image ([#4026](#4026)) ([f9fad65](f9fad65))
* copy repo page PR chart as image ([#4027](#4027)) ([3541a37](3541a37))
* display lottery factor on Repository Table ([#4059](#4059)) ([48343e0](48343e0))
* implemented the split button component ([#4040](#4040)) ([a539f78](a539f78))
* now html2canvas-pro is dynamically imported only when needed and then cached ([#4044](#4044)) ([23e4d76](23e4d76))
* OSCR learn more link opens in a new tab now ([#4056](#4056)) ([b8b1a00](b8b1a00))
* refresh explore page to only loading repositories ([#4019](#4019)) ([88f5937](88f5937))
* Use powerful self hosted runner for playwright tests ([#4069](#4069)) ([28f493e](28f493e))
* Use self hosted GitHub actions runners ([#4064](#4064)) ([d62066d](d62066d))

### 🐛 Bug Fixes

* `RossChart` order changing on filter ([#4018](#4018)) ([64a04f5](64a04f5))
* align OSCR pill with the username ([#4048](#4048)) ([0cc087d](0cc087d))
* correct width issue caused by tooltip addition in SingleSelect ([#4058](#4058)) ([b6e1173](b6e1173))
* fixed typo for recommendations ([#4017](#4017)) ([2e4cbdb](2e4cbdb))
* now if loading user profile fails an error is thrown instead of 404ing ([#4043](#4043)) ([3527795](3527795))
* now search dialog is always on top of other elements ([#4047](#4047)) ([3b4101a](3b4101a))
* remove deprecated "add coupon" section from user settings page ([#4039](#4039)) ([0b61b77](0b61b77))
* remove set width for repo pages charts ([#4068](#4068)) ([2dc9062](2dc9062))
* **ossfchart.tsx:** remove z-index and move "I want this now!" button JSX below ResponsiveContainer ([#4066](#4066)) ([8a9066a](8a9066a))
* repository page width overflow ([#4051](#4051)) ([b827d26](b827d26))
* Revert "fix: now search dialog is always on top of other elements ([#4047](#4047))" ([#4054](#4054)) ([cd03a01](cd03a01))
* update validation for GitHub username ([#4046](#4046)) ([8a77fac](8a77fac))
* Use correct github action yamls ([#4071](#4071)) ([9da2739](9da2739))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: repo page width overflowing on mobile view
3 participants