Proper user deletion / organization leaving #3460
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
pablonyx
force-pushed
the
feat/proper_user_leave
branch
from
c1a6fac to
07a7816
Compare
pablonyx
force-pushed
the
feat/proper_user_leave
branch
from
07a7816 to
7323fbe
Compare
yuhongsun96
reviewed
Dec 19, 2024
| user_to_delete: User, | ||
| db_session: Session, | ||
| ) -> None: | ||
| for oauth_account in user_to_delete.oauth_accounts: |
There was a problem hiding this comment.
deleting users is often kind of tricky, we need to delete everything related to that user no? Like chat sessions, files in the blob store, etc?
yuhongsun96
approved these changes
Dec 20, 2024
pablonyx
force-pushed
the
feat/proper_user_leave
branch
from
9be3690 to
00d7ba0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Allow any admin to leave their organization (in multi tenant case only)
Note that this will prevent them from creating a new instance if they were the owner of a previous one (intentional, but perhaps not the flow we want).
How Has This Been Tested?
Accepted Risk (provide if relevant)
Tested running multi tenant locally and
Related Issue(s) (provide if relevant)
N/A
Mental Checklist:
Backporting (check the box to trigger backport action)
Note: You have to check that the action passes, otherwise resolve the conflicts manually and tag the patches.