Show gamut in sliders #226
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for oddcontrast ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
jamesnw
commented
Dec 11, 2024
| <style lang="scss"> | ||
| @use 'config'; | ||
|
|
||
| [data-field='color-gamut'] { |
There was a problem hiding this comment.
This is copy pasted from SpaceSelect- should we make this a pattern somewhere?
jamesnw
commented
Dec 11, 2024
| color, | ||
| channel, | ||
| range, | ||
| gamut, |
There was a problem hiding this comment.
This is somewhat computationally slow. I toyed around with caching results, but the cache quickly grew to 12 Mbs in about 30 seconds of heavy usage 🫨 . I could likely do some more optimization if it is slow on slower machines.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds gamut boundaries to the sliders.
Also removes opacity from color channel sliders, and adds a checkerboard background to the opacity slider.
Related Issue(s)
#225
To test
Change gamut option, play with sliders.
Show me
https://deploy-preview-226--oddcontrast.netlify.app/
Todo