searching messages in specific partition #678
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bert-R
requested changes
Nov 8, 2024
| Integer maximumCount, | ||
| Date startTimestamp, | ||
| Deserializers deserializers) { | ||
| initializeClient(); | ||
| final List<TopicPartition> partitions = determinePartitionsForTopic(topic); | ||
| List<TopicPartition> partitions = determinePartitionsForTopic(topic); | ||
| if(partition != -1) { |
There was a problem hiding this comment.
Suggested change
| if(partition != -1) { | |
| if (partition != -1) { |
| List<TopicPartition> partitions = determinePartitionsForTopic(topic); | ||
| if(partition != -1) { | ||
| var partitionOpt = partitions.stream().filter(p -> p.partition() == partition).findAny(); | ||
| if(partitionOpt.isEmpty()) { |
There was a problem hiding this comment.
Suggested change
| if(partitionOpt.isEmpty()) { | |
| if (partitionOpt.isEmpty()) { |
| if(partition != -1) { | ||
| var partitionOpt = partitions.stream().filter(p -> p.partition() == partition).findAny(); | ||
| if(partitionOpt.isEmpty()) { | ||
| throw new IllegalArgumentException("Partition does not exists in the topic"); |
There was a problem hiding this comment.
Suggested change
| throw new IllegalArgumentException("Partition does not exists in the topic"); | |
| throw new IllegalArgumentException("Partition does not exist in topic"); |
| Integer maxmuimCount, | ||
| Date startTimestamp, | ||
| Deserializers deserializers) { | ||
| final var records = highLevelConsumer.searchRecords(topic, searchString, maxmuimCount, startTimestamp, | ||
| final var records = highLevelConsumer.searchRecords(topic, searchString, partition, maxmuimCount, startTimestamp, |
There was a problem hiding this comment.
Since you are making a change here anyway, do you mind fixing the spelling error in maximumCount (now spelled as maxmuimCount)?
|
Hi, thank you for the review. All issues should be fixed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi team,
in my usecase I usually know in which partition I need to search data. This will help me to reduce message consumption from partition that surely doesn't contain messages I want to search.
Option to search across all parition is preserved.