Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

shape tail in upheno file #961

Open
sbello opened this issue Sep 5, 2024 · 1 comment
Open

shape tail in upheno file #961

sbello opened this issue Sep 5, 2024 · 1 comment

Comments

@sbello
Copy link

sbello commented Sep 5, 2024

I assume the phenotype 'shape tail' in the uPheno file comes from this pattern

https://raw.githubusercontent.com/obophenotype/upheno/master/src/patterns/dosdp-dev/abnormalShapeOfAnatomicalEntityByShapeType.yaml

The way this has been entered we get a nonsensical phenotype term of 'shape tail' with a nonsensical definition 'Any structural anomaly that causes tail to be shape shaped.'

We should review and revise this pattern as needed. It maybe that general/grouping classes may need a variation on the standard label.

@sbello
Copy link
Author

sbello commented Dec 17, 2024

This is true of all the high level shape terms as a result of stripping the word 'abnormal' out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant