chore: simplify keep alive implementation #94
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
obmarg
force-pushed
the
obmarg/push-vpnkuwqwxmno
branch
from
f539c0c to
986cc73
Compare
Merged
obmarg
added a commit
that referenced
this pull request
Jun 8, 2024
#93 & #94 added a notion of keep alives to graphql-ws-client. But the implementation caused the connection to drop whenever no messages were received for the specified period. This isn't how I'd usually expect a keep alive to work though - I'd usually expect it to send pings during inactive periods, and only drop the connection if a few of those pings were not replied to. This PR implements that behaviour instead. It's a slightly breaking change over the earlier implementation, but that was not yet released so that seems fine.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A small tweak to #93 to avoid duplicating logic