Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove unused payload field from enum #119

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

hamirmahal
Copy link

closes #118.

Copy link
Author

@hamirmahal hamirmahal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These commands succeeded when I tested this change locally.

cargo build --workspace --all-features
cargo test --workspace --all-features --no-run
cargo test --workspace --all-features
cargo build --workspace --all-features --examples
cargo test --workspace --all-features --examples --no-run
cargo test --workspace --all-features --examples
cargo clippy --all --all-features

@obmarg
Copy link
Owner

obmarg commented Sep 9, 2024

Thanks for the contribution @hamirmahal - I'm not sure that removing those fields is the right fix though. Potentially should be exposing those fields to the user somehow rather than just removing them...

At the very least that's the case for the ConnectionAck one - and maybe the ping/pong ones as well (although I can see less obvious use cases for those ones).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

payload field in pub enum Event appears unused for ConnectionAck, Ping and Pong
2 participants