-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support skip & include on fields #900
Open
obmarg
wants to merge
11
commits into
main
Choose a base branch
from
obmarg/push-rlwlzxuwqsvo
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for cynic-querygen-web canceled.
|
obmarg
force-pushed
the
obmarg/push-rlwlzxuwqsvo
branch
2 times, most recently
from
April 9, 2024 21:13
03853ee
to
b621eb8
Compare
obmarg
force-pushed
the
obmarg/push-rlwlzxuwqsvo
branch
from
June 8, 2024 16:53
b621eb8
to
ca5b5e6
Compare
obmarg
force-pushed
the
obmarg/push-rlwlzxuwqsvo
branch
from
June 8, 2024 16:58
ca5b5e6
to
b62ae0a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For a long time cynic has not supported any directives. This PR adds support for the built in skip & include directives.
It does not add generalised directive support, although I'm not aware of many query directives that don't require explicit client support somehow. We can always add that later if needed.
Fixes #645