-
-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/ticket 1159 nxext stencil vue integration #1160
base: main
Are you sure you want to change the base?
Feature/ticket 1159 nxext stencil vue integration #1160
Conversation
…ueGenerator, including related tests
…et section, likewise for outputType
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 2f64ac7. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 2 targetsSent with 💌 from NxCloud. |
It was unclear how to build and test this locally. So please provide instructions on how to do that. So I may be able to resolve any issues. |
@NickersWeb you could use the e2e test for that. There are playground scripts but I'm not sure they're still working. I havent used them some time |
@DominikPieper As mentioned here: https://discord.com/channels/1143497901675401286/1314674305480790108/1316479200655442010 - I have encountered issues when trying to test these changes locally. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey, thanks for this. I think it would be nice to have e2e tests as well.
import { outputtargetGenerator } from './add-outputtarget'; | ||
import { AddOutputtargetSchematicSchema } from './schema'; | ||
|
||
xdescribe('add-outputtarget vue', () => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should not be skipped.
#1159