Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Build failed on msys2 windows #126 #136

Merged
merged 1 commit into from
Dec 12, 2024

Conversation

cgwkymt
Copy link
Contributor

@cgwkymt cgwkymt commented Dec 7, 2024

This PR is for #126 ("Build failed on msys2 windows").

Tested

make clean ; make

  • MSYS2 (MSYS, UCRT64, CLANG32, CLANG64, MINGW32, MINGW64)
    • Windows 11 (23H2)
    • GNU Make 4.4.1
    • gcc 13.3.0 on MSYS
    • gcc (Rev2, Built by MSYS2 project) 14.2.0 on UCRT64, MINGW32, MINGW64
    • clang 19.1.4 with gcc compat on CLANG32, CLANG64
  • WSL2 (Ubuntu 24.04.1 LTS)
    • Windows 11 (23H2)
    • GNU Make 4.3
    • gcc (Ubuntu 13.2.0-23ubuntu4) 13.2.0

Not tested

  • MSYS2 (CLANGARM64)

@cgwkymt
Copy link
Contributor Author

cgwkymt commented Dec 12, 2024

CI errors are caused by the followings. Would you confirm .github/workflows/ci.yml?

see : actions/runner-images#10721

Thank you,

@Conni2461
Copy link
Member

yeah i fix that, one sec

@Conni2461 Conni2461 merged commit dae2eac into nvim-telescope:main Dec 12, 2024
14 checks passed
@Conni2461
Copy link
Member

thanks :)

@cgwkymt cgwkymt deleted the fix/support_msys2 branch December 12, 2024 18:39
@cgwkymt
Copy link
Contributor Author

cgwkymt commented Dec 12, 2024

Thank you for accepting my mr!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants