New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement `pos = 'center'` option #9

Open

jesseleite wants to merge 1 commit into nvim-lua:master from jesseleite:pos-center

Contributor

jesseleite commented Mar 25, 2021 •

edited

Loading

Implement pos = 'center' option.
- You had this as a TODO.
- I had to rearrange a few things, as I needed access to width and height before setting line and col.
- The centering logic is ripped from Telescope; You ever heard of Telescope?
- Example usage...
```
local win_id, win = popup.create(bufnr, {
    minwidth = config.width or 60,
    minheight = config.height or 10,
    pos = 'center',
    -- ...
})
```


          Implement pos = ‘center’ option.

d68c2fb

jesseleite mentioned this pull request

Customizable menu window ThePrimeagen/harpoon#46

Merged

Member

tjdevries commented Aug 9, 2021

If you fix conflicts, I will merge. Sorry for the delay

l-kershaw mentioned this pull request

feat: allow pos="center", row=0, line=0 nvim-lua/plenary.nvim#227

Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet