Skip to content
This repository has been archived by the owner on Oct 13, 2021. It is now read-only.

Allow sorting items by source #345

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

pbogut
Copy link

@pbogut pbogut commented Feb 14, 2021

I've marked it as Work In Progress. Initially it sorts items just fine, but when I keep typing it starts to mixed up and it looks like items in in sort function are missing source_priority. I need to figure out what is happening there.
It was being dropped in util.addCompletionItems(), I've added source priority there to fix that.

It allows items to be sorted by source (issue #273).

It works similar to items_priority option. I extended sort function to check for source_priority and sort by it when available.
I had to add source_priority to completion items, and I think the only place where we have access to both is when completion items are fetched from external / internal sources, so I added change there. Source priority defaults to 1 if its not set.

Configuration:

vim.g.completion_source_priority = {
  lsp = 10,
  ['vim-dadbod-completion'] = 9,
  snippet = 5,
  ts = 7,
  buffers = 1,
}

or vim syntax:

let g:completion_source_priority = {
  \  'lsp': 10,
  \  'vim-dadbod-completion': 9,
  \  'snippet': 5,
  \  'ts': 7,
  \  'buffers': 1,
  \  }

@pbogut pbogut changed the title Allow sorting items by source Allow sorting items by source (WIP) Feb 15, 2021
@pbogut pbogut force-pushed the sort-items-by-source branch from cbae91a to 64c2a8c Compare February 15, 2021 12:12
@pbogut pbogut changed the title Allow sorting items by source (WIP) Allow sorting items by source Feb 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant