chore: update to eslint 9 and modern config (#700)

.github/workflows/ci.yml

@@ -33,5 +33,3 @@ jobs:
       - name: Linting
         if: ${{ matrix.node-version == '18' }}
         run: yarn lint
-      - name: Coverage
-        run: yarn coverage

.gitignore

@@ -29,7 +29,6 @@ dist
 
 # Testing
 reports
-coverage
 *.lcov
 .nyc_output
 

.size-limit.cjs

@@ -35,4 +35,4 @@ module.exports = [
     gzip: false,
     brotli: false,
   },
-];
+]

README.md

@@ -3,7 +3,6 @@
 
 [![npm version][npm-version-src]][npm-version-href]
 [![npm downloads][npm-downloads-src]][npm-downloads-href]
-[![Codecov][codecov-src]][codecov-href]
 [![Standard JS][standard-js-src]][standard-js-href]
 
 > [Sentry](http://sentry.io) module for [Nuxt 2](https://v2.nuxt.com/). For [Nuxt 3+](https://nuxt.com/) support see the official [`@sentry/nuxt` module](https://docs.sentry.io/platforms/javascript/guides/nuxt/).
@@ -28,7 +27,5 @@
 [npm-version-href]: https://npmjs.com/package/@nuxtjs/sentry
 [npm-downloads-src]: https://img.shields.io/npm/v/@nuxtjs/sentry/latest.svg?style=flat-square
 [npm-downloads-href]: https://npmjs.com/package/@nuxtjs/sentry
-[codecov-src]: https://img.shields.io/codecov/c/github/nuxt-community/sentry-module.svg?style=flat-square
-[codecov-href]: https://codecov.io/gh/nuxt-community/sentry-module
 [standard-js-src]: https://img.shields.io/badge/code_style-standard-brightgreen.svg?style=flat-square
 [standard-js-href]: https://standardjs.com

docs/.gitignore

@@ -5,7 +5,6 @@ node_modules
 .nuxt
 .vscode
 .DS_Store
-coverage
 dist
 sw.*
 .env

eslint.config.mjs

@@ -0,0 +1,68 @@
+import base from 'eslint-config-rchl-base'
+import typescript from 'eslint-config-rchl-typescript'
+import vue from 'eslint-config-rchl-vue'
+
+/** @type {import('eslint').Linter.Config[]} */
+export default [
+  {
+    ignores: [
+      '**/.nuxt/',
+      '**/dist/',
+      '**/templates/',
+      'node_modules/',
+    ],
+  },
+  ...base,
+  ...typescript,
+  ...vue,
+  {
+    rules: {
+      '@stylistic/indent': [
+        'error', 2, {
+          SwitchCase: 1,
+        },
+      ],
+      '@stylistic/semi': ['error', 'never'],
+      '@stylistic/space-before-function-paren': ['error', 'always'],
+    },
+  },
+  {
+    files: ['**/*.ts', '**/*.tsx'],
+    rules: {
+      '@stylistic/ts/indent': [
+        'error', 2, {
+          SwitchCase: 1,
+          FunctionDeclaration: { parameters: 'first' },
+          FunctionExpression: { parameters: 'first' },
+          CallExpression: { arguments: 'first' },
+        },
+      ],
+      '@stylistic/ts/member-delimiter-style': [
+        'error', {
+          multiline: {
+            delimiter: 'none',
+          },
+        },
+      ],
+      '@stylistic/ts/semi': ['error', 'never'],
+      '@stylistic/ts/space-before-function-paren': ['error', 'always'],
+    },
+  },
+  {
+    files: ['**/*.vue'],
+    rules: {
+      'vue/html-indent': ['error', 2],
+      'vue/script-indent': ['error', 2, { switchCase: 1 }],
+    },
+  },
+  {
+    files: ['**/.nuxt/*.js'],
+    rules: {
+      '@stylistic/comma-spacing': 'off',
+      '@stylistic/key-spacing': 'off',
+      '@stylistic/object-curly-spacing': 'off',
+      '@stylistic/quote-props': 'off',
+      '@stylistic/quotes': 'off',
+    },
+  },
+]

package.json

@@ -39,14 +39,13 @@
     "dev:generate": "nuxt generate -c ./test/fixture/default/nuxt.config --force-build",
     "analyze": "node ./node_modules/nuxt/bin/nuxt.js build --analyze -c ./test/fixture/default/nuxt.config",
     "size": "yarn build && cd size-check && yarn build && cd .. && yarn size-limit",
-    "lint": "eslint --ext .vue,.js,.ts .",
-    "lint:fix": "eslint --ext .vue,.js,.ts . --fix",
-    "lint:fixture": "eslint --ext .vue,.js --no-ignore 'test/fixture/*/.nuxt/sentry.*'",
+    "lint": "eslint .",
+    "lint:fix": "eslint . --fix",
+    "lint:fixture": "eslint --no-ignore 'test/fixture/*/.nuxt/sentry.*'",
     "release": "release-it",
     "test": "yarn prepack && vitest run --poolOptions.threads.singleThread && yarn lint:fixture && yarn typecheck",
     "test:watch": "vitest",
-    "typecheck": "yarn dev:prepare && tsc && tsc -p ./test/tsconfig.json",
-    "coverage": "codecov"
+    "typecheck": "yarn dev:prepare && tsc && tsc -p ./test/tsconfig.json"
   },
   "lint-staged": {
     "*.{js,ts,vue}": [
@@ -77,7 +76,6 @@
     "@nuxt/module-builder": "0.8.3",
     "@nuxt/types": "2.18.1",
     "@nuxt/typescript-build": "^3.0.2",
-    "@nuxtjs/eslint-config-typescript": "12.1.0",
     "@nuxtjs/module-test-utils": "1.6.3",
     "@release-it/conventional-changelog": "8.0.1",
     "@sentry/profiling-node": "7.119.0",
@@ -87,8 +85,10 @@
     "@types/lodash.mergewith": "4.6.9",
     "@types/node": "20.16.3",
     "@types/request-promise-native": "1.0.21",
-    "codecov": "3.8.3",
-    "eslint": "8.57.0",
+    "eslint": "^9.12.0",
+    "eslint-config-rchl-base": "^2.0.3",
+    "eslint-config-rchl-typescript": "^3.0.2",
+    "eslint-config-rchl-vue": "^3.0.0",
     "hookable": "5.5.3",
     "husky": "4.3.8",
     "lint-staged": "15.2.10",

size-check/base/pages/index.vue

@@ -5,7 +5,7 @@
     <h3>Client-side</h3>
     <span id="client-side">{{ clientSentryPresent ? 'Works!' : '$sentry object is missing!' }}</span>
     <p>
-      <button id="crash-button" @click="crash_me()">
+      <button id="crash-button" type="button" @click="crash_me()">
         crash me
       </button>
     </p>

size-check/lazy+tracing/pages/index.vue

@@ -5,7 +5,7 @@
     <h3>Client-side</h3>
     <span id="client-side">{{ clientSentryPresent ? 'Works!' : '$sentry object is missing!' }}</span>
     <p>
-      <button id="crash-button" @click="crash_me()">
+      <button id="crash-button" type="button" @click="crash_me()">
         crash me
       </button>
     </p>

size-check/lazy/pages/index.vue

@@ -5,7 +5,7 @@
     <h3>Client-side</h3>
     <span id="client-side">{{ clientSentryPresent ? 'Works!' : '$sentry object is missing!' }}</span>
     <p>
-      <button id="crash-button" @click="crash_me()">
+      <button id="crash-button" type="button" @click="crash_me()">
         crash me
       </button>
     </p>

size-check/replay/pages/index.vue

@@ -5,7 +5,7 @@
     <h3>Client-side</h3>
     <span id="client-side">{{ clientSentryPresent ? 'Works!' : '$sentry object is missing!' }}</span>
     <p>
-      <button id="crash-button" @click="crash_me()">
+      <button id="crash-button" type="button" @click="crash_me()">
         crash me
       </button>
     </p>

size-check/tracing/pages/index.vue

@@ -5,7 +5,7 @@
     <h3>Client-side</h3>
     <span id="client-side">{{ clientSentryPresent ? 'Works!' : '$sentry object is missing!' }}</span>
     <p>
-      <button id="crash-button" @click="crash_me()">
+      <button id="crash-button" type="button" @click="crash_me()">
         crash me
       </button>
     </p>

size-check/typescript/pages/index.vue

@@ -5,7 +5,7 @@
     <h3>Client-side</h3>
     <span id="client-side">{{ clientSentryPresent ? 'Works!' : '$sentry object is missing!' }}</span>
     <p>
-      <button id="crash-button" @click="crash_me()">
+      <button id="crash-button" type="button" @click="crash_me()">
         crash me
       </button>
     </p>
@@ -19,7 +19,6 @@ export default defineComponent({
   asyncData ({ $sentry, query }) {
     if (query.crashOnLoad) {
       // @ts-ignore forces a crash
-      // eslint-disable-next-line no-undef
       crashOnLoad()
     }
 

src/hooks.ts

@@ -20,7 +20,7 @@ export async function buildHook (nuxt: Nuxt, moduleOptions: ModuleConfiguration,
 
   const templateDir = fileURLToPath(new URL('./templates', import.meta.url))
 
-  const pluginOptionClient = clientSentryEnabled(moduleOptions) && canInitialize(moduleOptions) ? (moduleOptions.lazy ? 'lazy' : 'client') : 'mocked'
+  const pluginOptionClient = clientSentryEnabled(moduleOptions) && canInitialize(moduleOptions) ? moduleOptions.lazy ? 'lazy' : 'client' : 'mocked'
   const clientOptions: ResolvedClientOptions = defu({ config: { release } }, await resolveClientOptions(nuxt, moduleOptions, logger))
   addPluginTemplate({
     src: resolve(templateDir, `plugin.${pluginOptionClient}.js`),
@@ -65,7 +65,7 @@ export async function buildHook (nuxt: Nuxt, moduleOptions: ModuleConfiguration,
 export async function webpackConfigHook (nuxt: Nuxt, webpackConfigs: WebpackConfig[], options: ModuleConfiguration, logger: ConsolaInstance): Promise<void> {
   let WebpackPlugin: typeof import('@sentry/webpack-plugin')
   try {
-    WebpackPlugin = await (import('@sentry/webpack-plugin').then(m => m.default || m))
+    WebpackPlugin = await import('@sentry/webpack-plugin').then(m => m.default || m)
   } catch {
     throw new Error('The "@sentry/webpack-plugin" package must be installed as a dev dependency to use the "publishRelease" option.')
   }