Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix sw.js overwrite #19

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

luisjoserivera
Copy link

Fixes #1

@codecov
Copy link

codecov bot commented Oct 17, 2020

Codecov Report

Merging #19 into master will decrease coverage by 5.00%.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #19      +/-   ##
==========================================
- Coverage   75.00%   70.00%   -5.00%     
==========================================
  Files           2        2              
  Lines          48       50       +2     
  Branches        9       11       +2     
==========================================
- Hits           36       35       -1     
- Misses         12       15       +3     
Impacted Files Coverage Δ
lib/module.js 64.10% <66.66%> (-6.17%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 885888d...653df8f. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

$OneSignal sometimes works in a PROD environment, sometimes not, in DEV enviroment works fine
1 participant