Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: change homepage url #33

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

mikana0918
Copy link

issue

#32

about

The link was invalid on npm site because the homepage link on the package.json was not valid.
I changed to valid homepage url.

@codecov
Copy link

codecov bot commented Apr 14, 2021

Codecov Report

Merging #33 (ac1af32) into main (d615e56) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##              main       #33   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            2         2           
  Lines           11        11           
  Branches         1         1           
=========================================
  Hits            11        11           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d615e56...ac1af32. Read the comment docs.

package.json Outdated
@@ -1,7 +1,7 @@
{
"name": "@nuxtjs/markdownit",
"version": "2.0.0",
"homepage": "nuxt-community/markdownit-module",
"homepage": "https://github.com/nuxt-community/markdownit-module",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we need to use "repo" instead of homepage for fixing ☺️

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pi0 I deal with the commit☺️ ac1af32 I appreciate your review, thank you!:3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants