feat: Add option to address "Rogue Referral" issue when tracking paid traffic via GTM+GA #117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mraichelson
changed the title
|
I could use some assistance to find out how to address the CI/testing issue that's occurred here. |
|
@pi0 Could we get this PR look into, reviewed, and merged, please? |
|
Happy birthday little PR! Hard to believe it's been a year. You've come so far since you were first opened. |
|
Merge please. We've spent a lot of time before finding out that we have rouge referral problem |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses Issue #114 by re-implementing the changes from PRs #74 and #86 against an updated base branch.
Thanks to @sahava for identifying what the issue actually is, and to @wusongliang (PR74) and @jeffski (PR86) for their effort to actually build a fix for this.