-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tests: refactor tests #649
base: main
Are you sure you want to change the base?
Conversation
Memory usage did not change for any of the samples. |
b45a9c4
to
9c04745
Compare
b9d68f7
to
ddcf163
Compare
1906f7c
to
28e2d02
Compare
28e2d02
to
45d564a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
crypto
mfg
spi
storage
Require rewriting or major refactoring. Please move them to their old location, as they will be addressed in separate PRs.
If some test does not pass, please skip it and place it back in its old location (move to tests_new, only refactored/approved and working tests)
tests_new/integration/storage/boards/nrf54l15dk_nrf54l15_cpuapp_ns.overlay
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
refactor tests, tests are coupled, need to be run in order, commented test
tests_new/integration/spi/src/main.c
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/**
- Test spi transfer, reuse external flash because it is already on DK? otherwise this test will require some fixture to run
*/
tests_new/integration/mfg/src/main.c
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/**
TODO rewrite the test
read suite:
v7
v8
write suite:
clear memory,
write values
read values
compare
persistant test
write values
dump flash to different address
initialize on new address (copy)
read values
compare
*/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#if defined(CONFIG_SOC_SERIES_NRF54LX)
// TODO: this ifdef should be based on feature not SOC used. replace it by feature: SID_PAL_HASH_SHA512 check
/**
I want to see what configurations were tested. Maybe some kind of matrix that show what function with what algorithms, and what values were tested
what error cases were covered
each function should have its own suite maybe some kind of macro generation of test functions would be usefull to make this information more compact
maybe separating functions, into separate files would be benefitial
maybe some defines, should be moved to Kconfig of the test, or separate configuration header.
Simmilarly there are many schemes like test_data, correct_response. extracting those long data arrays would make tests more redeable.
*/
[KRKNWK-14886] * Move critical_region test to new location * Move crypto keys test to new location * Move crypto test to new location * Move delay test to new location * Move interrupts test to new location * Move spi test to new location * Move storage test to new location * Move temperature test to new location * Move time test to new location * Add native_sim board support (not all) * Port to ztest * Remove sanity tests Signed-off-by: Krzysztof Taborowski <[email protected]>
Tests skipped - to be rewritten Signed-off-by: Krzysztof Taborowski <[email protected]>
Use mock temperature pal when no temp sensor in dts Signed-off-by: Krzysztof Taborowski <[email protected]>
45d564a
to
dd5e6a8
Compare
to be squashed Signed-off-by: Krzysztof Taborowski <[email protected]>
to be fixed later Signed-off-by: Krzysztof Taborowski <[email protected]>
KRKNWK-14886
Move and refactor tests:
mfgnot workingCI parameters
Description
JIRA ticket:
Self review