Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NEXT.js Rebuild #3

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Ben-Bromley
Copy link

Rebuild in NEXT.js with a more modern feel, more prevalent logo placement, and social links

image image

@Ben-Bromley
Copy link
Author

Just some tinkering of mine. Feel free to close if this isn't of interest.

@FreneticScribbler
Copy link
Member

Hate to be that guy, especially on something I didn't build, but this feels like using a nuclear warhead to crack a nut...why do we need a JavaScript framework to produce a single page of html?

Design itself does look nicer, just don't see why it can't be just HTML. How does the network weight, load time and accessibility compare to the old site?

By all means ignore me as 'that guy' (I generally did!) but the continued spread of JS frameworks as the web default makes me very sad.

@Ben-Bromley
Copy link
Author

You are completely right, it's overkill. Mostly just having some fun and accidentally opened a PR into the main repo instead of my fork.

NEXT.js should have Static Site Generation, so it's still pure HTML being served, but we get the fun framework side of things to work on. Still need to look at performance and accessibility on this.

I think the main idea that interested me was then using a json file to dictate content like the below. Similar to how some frameworks use yaml or markdown etc. Abstracting some of the logic so that if we ever have a IT manager who is not particularly interested in coding, they could still get involved with updating things like this.

{
  "socials": [
    "instagram": {
       "iconSrc": "/instagram.svg",
       "url": "https://instagram.com/nottinghamtec/"
    },
    "etc": {},
  ],
  "links": [
    "main": {
       "url": "https://nottinghamtec.co.uk/",
       "text": "Main Website",
     },
     "etc": {},
  ]
}

@FreneticScribbler
Copy link
Member

Ah, I retract some of my grumbling then, I misunderstood what NEXT.js was. I do like static site generators, specifially because what they produce is regular html as you say. Personally I'm a Hugo guy, though. They arent kidding when they sell it as fast!

Data files definitely do seem to make updates more accessible, we use that for the main site and for join with success.

Then again, if people are happy editing JSON or YAML, what's making them afraid of editing the HTML? 🤔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants