Skip to content

Commit

Permalink
Switch back to v4 API; getSeries now fixed
Browse files Browse the repository at this point in the history
  • Loading branch information
notZaki committed Dec 2, 2020
1 parent 46c9b9c commit ad987e5
Show file tree
Hide file tree
Showing 3 changed files with 2 additions and 6 deletions.
2 changes: 1 addition & 1 deletion Project.toml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
name = "CancerImagingArchive"
uuid = "1c555f4c-8d6b-45c3-bbc1-c64989f538fe"
version = "1.1.1"
version = "1.1.2"

[deps]
CSV = "336ed68f-0bac-5ca0-87d4-7b16caf5d00b"
Expand Down
3 changes: 1 addition & 2 deletions src/CancerImagingArchive.jl
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@ export tcia_single_image, tcia_images
export dataframe_to_csv, dictionary_to_json

const _host = "services.cancerimagingarchive.net/services/v4/TCIA/query"
const _host_for_series = "services.cancerimagingarchive.net/services/v3/TCIA/query"
const _format = "csv"
const _q = Dict(
:collection => "Collection",
Expand Down Expand Up @@ -164,7 +163,7 @@ function tcia_series(; collection = "", bodypart = "", manufacturer = "", modali
_q[:study] => study,
_q[:format] => format
)
return request(endpoint, query; host = _host_for_series)
return request(endpoint, query)
end

"""
Expand Down
3 changes: 0 additions & 3 deletions test/runtests.jl
Original file line number Diff line number Diff line change
Expand Up @@ -132,9 +132,6 @@ end
compare_csv_vs_json(
tcia_series(collection = "TCGA-THCA"),
tcia_series(collection = "TCGA-THCA", format = "json"), max_names = 3)
compare_csv_vs_json(
tcia_series(patient = "TCGA-QQ-A8VF"),
tcia_series(patient = "TCGA-QQ-A8VF", format = "json"), max_names = 3)
compare_csv_vs_json(
tcia_series(study = "1.3.6.1.4.1.14519.5.2.1.3023.4024.298690116465423805879206377806"),
tcia_series(study = "1.3.6.1.4.1.14519.5.2.1.3023.4024.298690116465423805879206377806", format = "json"), max_names = 3)
Expand Down

2 comments on commit ad987e5

@notZaki
Copy link
Owner Author

@notZaki notZaki commented on ad987e5 Dec 2, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JuliaRegistrator register()

@JuliaRegistrator
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Registration pull request created: JuliaRegistries/General/25717

After the above pull request is merged, it is recommended that a tag is created on this repository for the registered package version.

This will be done automatically if the Julia TagBot GitHub Action is installed, or can be done manually through the github interface, or via:

git tag -a v1.1.2 -m "<description of version>" ad987e56bddfe05af693fd02891f09a1a7d6f465
git push origin v1.1.2

Please sign in to comment.