-
Notifications
You must be signed in to change notification settings - Fork 563
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fetch: add docs on why forbidden header names are not supported #3696
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes in comments, @KhafraDev ptal
I find the comments harder to read considering it merges two different spec functions (I understand they're out of date). I don't see any value in documenting why we don't implement forbidden headers either as it's well-known and documented already. |
The benefit is for developers who read the code on while going through the implementation. |
The source code is for https://fetch.spec.whatwg.org/#concept-headers-append The screenshot provided is for https://fetch.spec.whatwg.org/#headers-class |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should not land per my comment
This relates to...
Changes
Documents why undici fetch does not support forbidden header names
Features
N/A
Bug Fixes
N/A
Breaking Changes and Deprecations
N/A
Status