NameIDFormat fix (#375)

Added a conditional statement to set NameIDFormat only if identifierFormat is specified in options. This should prevent an error in AD FS when identifierFormat set to null: #338
node-saml · Jul 26, 2019 · 6f0876e · 6f0876e
1 parent 5cdf341
commit 6f0876e
Showing 1 changed file with 4 additions and 1 deletion.
diff --git a/lib/passport-saml/saml.js b/lib/passport-saml/saml.js
@@ -1249,7 +1249,10 @@ SAML.prototype.generateServiceProviderMetadata = function( decryptionCert, signi
     };
   }
 
-  metadata.EntityDescriptor.SPSSODescriptor.NameIDFormat = this.options.identifierFormat;
+  if (this.options.identifierFormat) {
+    metadata.EntityDescriptor.SPSSODescriptor.NameIDFormat = this.options.identifierFormat;
+  }
+
   metadata.EntityDescriptor.SPSSODescriptor.AssertionConsumerService = {
     '@index': '1',
     '@isDefault': 'true',