Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: nocobase/docs#132 #133

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

pranshul7
Copy link
Contributor

Translated the handbook content @ https://docs.nocobase.com/handbook/data-source-rest-api to English (US) language, which was originally in Chinese; for en-US.

Some of the illustration images at the webpage also contain text in Chinese which require replacement, but those images have not been replaced in this PR yet.

@pranshul7
Copy link
Contributor Author

@mytharcher Can you please help me understand why these checks are failing and what is the issue, so that I can correct it.

@mytharcher
Copy link
Contributor

Thanks @pranshul7 for your contribution!

The failed check item, which is the CI for deployment will not run on forked PRs. We will deploy it manually later for reviewing.

@pranshul7
Copy link
Contributor Author

Oh okay. Thanks @mytharcher for helping me out. I was worrying since then what has gone wrong on my part.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants