-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Testing Firebase second generation #78
base: firebase
Are you sure you want to change the base?
Conversation
firebase-second-gen-preset/entry.ts
Outdated
const onRequestDefaults = { | ||
memory: "1GiB", | ||
// TODO: does this change anything? | ||
invoker: "public", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to enforce this otherwise the google cloud permissions aren't set properly, and they can only be changed with the gcloud cli (not the firebase cli or the dashboard)
We figured that out in the firebase-v2 pr preset
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, this is the kind of things that are hard to deal with in Firebase projects 😓 , it's the part that is not always document or easy to find
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What I find weird is that it wasn't necessary in gen 1?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
They changed the way permissions works at the gcloud level
Do we want to test only one of the two presets, or both v1 or v2 ? |
I think testing just the latest gen is fine |
Discussed with @pi0
Still needs to be deployed manually with
firebase deploy
by the owner to update functions